Red Hat Bugzilla – Bug 823798
lookupFileInfo and createOrUpdatePath issues for binary files
Last modified: 2012-10-15 09:47:18 EDT
+++ This bug was initially created as a clone of Bug #801463 +++
In the latest 1.7 release of spacewalk, lookupFileInfo still returns an empty content for binary files, while getEncodedFileRevision does return the content (base64 encoded I guess). Also createOrUpdatePath has no means to specify that the uploaded file is binary.
So what I suggest:
- either change lookupFileInfo to always return base64 encoded contents, or create a new API call lookupEncodedFileInfo for that
- add the "binary" option createOrUpdatePath, so we can specify that a file is binary
Tomas Lestach 2012-03-13 11:54:32 CET
I fixed several issues for binary config files. Some of them:
configchannel.createOrUpdatePath now accepts also binary attribute
configchannel.createOrUpdatePath - fixed handling of binary files
configchannel.lookupFileInfo now returns base64 encoded content for binary files
I recommend to upload xml config files base64 encoded.
If you see any other issues, please open another BZ. (I tried to address as many as possible within this one.)
Changing the RFE to a bugfix BZ as the upload of binary files via API was broken.
Everything works almost like charm, except combination
> , "binary": True
> , "contents_enc64": False
After discussion with assignee we came to conclusion that this behavior might need some reconsideration (some input checking or at least documentation expansion), so switching back to assigned...
I forgot to mention that mentioned "except" part of Comment #4 is about configchannel.createOrUpdatePath, expetially "path info" parameter.
Updating API documentation ...
I verify that functionality for
works the way that (at least from my point of view) can be understood from documentation. (Also configchannel.lookupFileInfo returns content for binary files, just to explicitly say...).