RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 823843 - cifs: Fix oplock break handling
Summary: cifs: Fix oplock break handling
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: kernel
Version: 6.4
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Sachin Prabhu
QA Contact: Jian Li
URL:
Whiteboard:
Depends On:
Blocks: 798385
TreeView+ depends on / blocked
 
Reported: 2012-05-22 09:59 UTC by Sachin Prabhu
Modified: 2014-03-04 00:08 UTC (History)
5 users (show)

Fixed In Version: kernel-2.6.32-298.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-21 05:56:48 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0496 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 6 kernel update 2013-02-20 21:40:54 UTC

Description Sachin Prabhu 2012-05-22 09:59:56 UTC 
Backport of the following upstream patch
--
commit 12fed00de963433128b5366a21a55808fab2f756
Author: Pavel Shilovsky <piastryyy>
Date:   Mon Jan 17 20:15:44 2011 +0300

CIFS: Fix oplock break handling (try #2)

When we get oplock break notification we should set the appropriate
value of OplockLevel field in oplock break acknowledge according to
the oplock level held by the client in this time. As we only can have
level II oplock or no oplock in the case of oplock break, we should be
aware only about clientCanCacheRead field in cifsInodeInfo structure.

Also fix bug connected with wrong interpretation of OplockLevel field
during oplock break notification processing.

Signed-off-by: Pavel Shilovsky <piastryyy>
Cc: <stable>
Signed-off-by: Steve French <sfrench.com>
--
Comment 2 RHEL Program Management 2012-07-27 16:21:11 UTC 
This request was evaluated by Red Hat Product Management for
inclusion in a Red Hat Enterprise Linux release.  Product
Management has requested further review of this request by
Red Hat Engineering, for potential inclusion in a Red Hat
Enterprise Linux release for currently deployed products.
This request is not yet committed for inclusion in a release.
Comment 3 Jian Li 2012-08-01 06:00:23 UTC 
according to patch, oplock breaking test are needed (and data cache).
Comment 4 Jarod Wilson 2012-08-16 21:22:13 UTC 
Patch(es) available on kernel-2.6.32-298.el6
Comment 7 Jian Li 2013-02-01 16:29:32 UTC 
This bug is verified 2.6.32-356.el6.i686, reproduced on 2.6.32-296.el6.i686. 

Two clients, the 1st one open the shared file with 'r+' mode, it get exclusive lock.  after then, the 2nd one open the shared file with 'r' mode, server send 'oplock break notify' to 1st client.

1st mount: mount.cifs //server/cifs /mnt/test -o password=xxxx
2nd mount: mount.cifs //server/cifs /mnt/test -o cache=null,passowrd=xxxx

Reproducer, message from dmesg when open cifsFYI(7):
#dmesg
** snip **
fs/cifs/misc.c: Checking for oplock break or dnotify response
fs/cifs/misc.c: oplock type 0x2 level 0x1
fs/cifs/misc.c: file id match, oplock break
fs/cifs/misc.c: Exclusive Oplock granted on inode f2d9d070
fs/cifs/file.c: Oplock flush inode f2d9d070 rc 0

and after the 2nd one open file (cache=null), 1st client write data to file, the 2nd client couldn't got the latested data.


Verifer:

[root@hp-xw4600-01 ~]# dmesg
**snip**
fs/cifs/connect.c: rfc1002 length 0x37
fs/cifs/misc.c: Checking for oplock break or dnotify response
fs/cifs/misc.c: oplock type 0x2 level 0x1
fs/cifs/misc.c: file id match, oplock break
fs/cifs/misc.c: Level II Oplock granted on inode f5a15070
fs/cifs/file.c: Oplock flush inode f5a15070 rc 0
fs/cifs/cifssmb.c: CIFSSMBLock timeout 0 numLock 0
fs/cifs/transport.c: For smb_command 36
fs/cifs/transport.c: Sending smb:  total_len 55
fs/cifs/misc.c: Null buffer passed to cifs_small_buf_release
fs/cifs/file.c: Oplock release rc = 0

and there is not data cache problem
Comment 9 errata-xmlrpc 2013-02-21 05:56:48 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0496.html
Note You need to log in before you can comment on or make changes to this bug.