SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 Description: A Vietnamese engine for Fcitx that uses Unikey.
(In reply to comment #0) > SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec > SRPM: > http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.0-1.fc16.src.rpm > Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 > Description: > A Vietnamese engine for Fcitx that uses Unikey. I post a wrong SRPM URL. Here is a correct URL. SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 Description: A Vietnamese engine for Fcitx that uses Unikey.
*** Bug 824063 has been marked as a duplicate of this bug. ***
Any particular reason you assigned this to me? I can try and help review, but I'm pretty busy and likely won't get to it very soon...
Kevin, I will help the submitter with this package review like I did for his other fcitx-* package reviews. Taking this for review.
Review:- + Koji build used ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4094915 + rpmlint on rpms gave fcitx-unikey.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-unikey-0.1.0.tar.xz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 1 warnings. ==> This can be ignored + Source verified with upstream as (sha1sum) ef57f512d3ded16f6656be5e07e4465cbf13ffd5 fcitx-unikey-0.1.0.tar.xz ef57f512d3ded16f6656be5e07e4465cbf13ffd5 ../SOURCES/fcitx-unikey-0.1.0.tar.xz Suggestions: 1) each pushd command should have corresponding popd. please add it in %build 2) I am not sure about final license tag. As ukengine part is in LGPLv2+, VnConv is in GPLv2+ and your own code is in GPLv3+. Can you check with upstream? Guess you need to change your code from GPLv3+ to GPLv2+ 3) The correct way to handle locale files is remove manually generation of %{name}.lang in spec file and use "%find_lang %{name}" at the end of %install section. See https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
I asked on #fedora-devel and come to know that without changing source license, this package can have license tag as GPLv3+
any update here?
Can you please provide update here so that once package review completes and built in fedora, will be available for testing?
liangsuilong, If you are busy with your work then please allow me to fix this package and request SCM for this package and build it in Fedora so that people can use this.
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-unikey.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.0-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4328977
It would have been good if you could have added some changelog and bumped the release tag for above change. APPROVED.
Hi Liang, If you are busy, can I request you to allow me to import this package and co-own with you this package?
No response from reporter since last 4 months here. If you still want this package in fedora then just reopen this and request for git package module. For now closing...
New Package SCM Request ======================= Package Name: fcitx-unikey Short Description: Vietnamese Engine for Fcitx Owners: liangsuilong Branches: f16 f17 f18 el6 InitialCC: i18n-team
Git done (by process-git-requests).
fcitx-unikey-0.1.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fcitx-unikey-0.1.1-2.fc18
fcitx-unikey-0.1.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-unikey-0.1.1-2.fc17
fcitx-unikey-0.1.1-2.fc18 has been pushed to the Fedora 18 testing repository.
fcitx-unikey-0.1.1-2.fc17 has been pushed to the Fedora 17 stable repository.
fcitx-unikey-0.1.1-2.fc18 has been pushed to the Fedora 18 stable repository.