Bug 824430 - Review Request: perl-Syntax-Feature-Loop - Provides the loop BLOCK syntax for unconditional loops
Review Request: perl-Syntax-Feature-Loop - Provides the loop BLOCK syntax for...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Petr Pisar
Fedora Extras Quality Assurance
:
Depends On: 823523 823989 824393
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-23 09:00 EDT by Jitka Plesnikova
Modified: 2012-05-31 11:03 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-05-31 11:03:14 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ppisar: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Jitka Plesnikova 2012-05-23 09:00:33 EDT
Spec URL: http://jplesnik.fedorapeople.org/perl-Syntax-Feature-Loop/perl-Syntax-Feature-Loop.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Syntax-Feature-Loop/perl-Syntax-Feature-Loop-1.6.0-1.fc18.src.rpm
Description: Syntax::Feature::Loop is a lexically-scoped pragma that provides the loop BLOCK syntax for unconditional loops.
Fedora Account System Username: jplesnik@redhat.com
Comment 1 Petr Pisar 2012-05-31 09:41:33 EDT
Source file is original. Ok.
Summary verified from lib/Syntax/Feature/Loop.pm. Ok.
License verified from lib/Syntax/Feature/Loop.pm and LICENSE. Ok.
Description verified from lib/Syntax/Feature/Loop.pm. Ok.
XS code presents, BuildArch is Ok.
URL and Source0 are usable. Ok.

TODO: Build-require `perl(XSLoader)' (lib/Syntax/Feature/Loop.pm:9).
TODO: Qualify build-requirement perl(Test::Pod) with `>= 1.22' (t/pod.t:8).

The Software::License::CC0_1_0 module is nowhere used. Ok.

All tests pass. Ok.

$ rpmlint perl-Syntax-Feature-Loop.spec ../SRPMS/perl-Syntax-Feature-Loop-1.6.0-1.fc18.src.rpm ../RPMS/x86_64/perl-Syntax-Feature-Loop-*
perl-Syntax-Feature-Loop.src: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically
perl-Syntax-Feature-Loop.src: W: spelling-error %description -l en_US pragma -> pragmatic
perl-Syntax-Feature-Loop.x86_64: W: spelling-error %description -l en_US lexically -> lexical, exotically, allergically
perl-Syntax-Feature-Loop.x86_64: W: spelling-error %description -l en_US pragma -> pragmatic
3 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-Syntax-Feature-Loop-1.6.0-1.fc18.x86_64.rpm
drwxr-xr-x    2 root    root                        0 May 31 15:26 /usr/lib64/perl5/vendor_perl/Syntax
drwxr-xr-x    2 root    root                        0 May 31 15:26 /usr/lib64/perl5/vendor_perl/Syntax/Feature
-rw-r--r--    1 root    root                     3320 May 31 15:26 /usr/lib64/perl5/vendor_perl/Syntax/Feature/Loop.pm
drwxr-xr-x    2 root    root                        0 May 31 15:26 /usr/lib64/perl5/vendor_perl/auto/Syntax
drwxr-xr-x    2 root    root                        0 May 31 15:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Feature
drwxr-xr-x    2 root    root                        0 May 31 15:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Feature/Loop
-rwxr-xr-x    1 root    root                     6120 May 31 15:26 /usr/lib64/perl5/vendor_perl/auto/Syntax/Feature/Loop/Loop.so
drwxr-xr-x    2 root    root                        0 May 31 15:26 /usr/share/doc/perl-Syntax-Feature-Loop-1.6.0
-rw-r--r--    1 root    root                      338 May 19 01:19 /usr/share/doc/perl-Syntax-Feature-Loop-1.6.0/Changes
-rw-r--r--    1 root    root                     7075 May 19 01:19 /usr/share/doc/perl-Syntax-Feature-Loop-1.6.0/LICENSE
-rw-r--r--    1 root    root                     1529 May 19 01:19 /usr/share/doc/perl-Syntax-Feature-Loop-1.6.0/README.txt
-rw-r--r--    1 root    root                     2999 May 31 15:26 /usr/share/man/man3/Syntax::Feature::Loop.3pm.gz
File layout and permissions is Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-Syntax-Feature-Loop-1.6.0-1.fc18.x86_64.rpm |sort |uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 perl(Devel::CallParser)
      1 perl(Lexical::Sub)
      1 perl(:MODULE_COMPAT_5.14.2)
      1 perl(strict)
      1 perl(syntax) >= 0.004
      1 perl(version)
      1 perl(warnings)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-Syntax-Feature-Loop-1.6.0-1.fc18.x86_64.rpm |sort |uniq -c
      1 perl(Syntax::Feature::Loop)
      1 perl-Syntax-Feature-Loop = 1.6.0-1.fc18
      1 perl-Syntax-Feature-Loop(x86-64) = 1.6.0-1.fc18
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-Syntax-Feature-Loop-1.6.0-1.fc18.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4116870). Ok.

Package is in line with Fedora and Perl packaging guidelines.


Please consider fixing the `TODO' items before building this package.

Resolution: Package APPROVED.
Comment 2 Jitka Plesnikova 2012-05-31 10:01:18 EDT
New Package SCM Request
=======================
Package Name: perl-Syntax-Feature-Loop
Short Description: Provides the loop BLOCK syntax for unconditional loops
Owners: jplesnik mmaslano ppisar psabata
Branches:
InitialCC: perl-sig
Comment 3 Gwyn Ciesla 2012-05-31 10:11:05 EDT
Git done (by process-git-requests).
Comment 4 Jitka Plesnikova 2012-05-31 11:03:14 EDT
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.