In .gtmpl file, I use: <input class="key" type="text" name="key" value="${key}"/> And if "key" variable is null, I will get "null" string in input like: <input type="text" name="key" value="null"> I think it should not be, we should print nothing when variable is null, for example: <input type="text" name="key" value>
Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: C: GTMPL template prints null, when key was not definned C: Non valid string shown on page R: Use empty string F: Returning empty string instead of null.
xercesImpl-2.9.1-patch-01.jar are now used. any ideas how to check if this version has the right patch in it?
Boleslaw Dawidowicz <boleslaw.dawidowicz> made a comment on jira GTNPORTAL-2373 Kien is the patch commited in gatein? Could you confirm and resolve?
There is a side effect on EPP-SP 5.2.2-ER02, see https://jira.exoplatform.org/browse/SPUB-191 for the detail.
Needs be updated based on https://jira.exoplatform.org/browse/SPUB-191
Updated Signin.xml in branding script.
kien nguyen <nguyenanhkien2a> made a comment on jira GTNPORTAL-2373 @Trang Vu: how to verify side effect of https://jira.exoplatform.org/browse/SPUB-191 because the patch has not yet commited on gatein?
kien nguyen <nguyenanhkien2a> made a comment on jira GTNPORTAL-2373 It seems to the patch had committed on EPP. And now, Groovy engine will render "" instead of "null", so side effect will occur if your javascript is only processing by based on "null" value
Customers whose sites are based on ACME portal template will have to update their Signin.xml manually. We should revert the commit 8713 to avoid such kind of impact.
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1,4 +1 @@ -C: GTMPL template prints null, when key was not definned +If a GateIn Template file (*.gtmpl) contained an <input> directive that declared a variable as a value, and that variable resolved to null, the word "null" would be substituted for the value instead of the value parameter being present, but undefined. For example, <input class="key" type="text" name="key" value="${key}"/> resolved to <input class="key" type="text" name="key" value="null"/>, instead of <input class="key" type="text" name="key" value/>. The fix corrects the way null values are handled, and now prints undefined parameters, instead of printing null as the parameter value.-C: Non valid string shown on page -R: Use empty string -F: Returning empty string instead of null.
Technical note updated. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1 +1 @@ -If a GateIn Template file (*.gtmpl) contained an <input> directive that declared a variable as a value, and that variable resolved to null, the word "null" would be substituted for the value instead of the value parameter being present, but undefined. For example, <input class="key" type="text" name="key" value="${key}"/> resolved to <input class="key" type="text" name="key" value="null"/>, instead of <input class="key" type="text" name="key" value/>. The fix corrects the way null values are handled, and now prints undefined parameters, instead of printing null as the parameter value.+If a GateIn Template file (*.gtmpl) contained an <input> directive that declared a variable as a value, and that variable resolved to null, the word "null" would be substituted for the value instead of the value parameter being present, but undefined. For example, <input class="key" type="text" name="key" value="${key}"/> resolved to <input class="key" type="text" name="key" value="null"/>, instead of <input class="key" type="text" name="key" value/>. The fix corrects the way null values are handled, and now prints undefined parameters, instead of printing null as the parameter value.
kien nguyen <nguyenanhkien2a> made a comment on jira GTNPORTAL-2373 Some side effect of https://jira.exoplatform.org/browse/SPUB-191 are resolved and patch was committed in EPP. The patch need to be committed in GateIn
Vu Viet Phuong <vstorm83> made a comment on jira GTNPORTAL-2373 Backport from https://bugzilla.redhat.com/show_bug.cgi?id=824863
Trong Tran <trongtt> made a comment on jira GTNPORTAL-2373 printing "null" is an expected behavior from Groovy template engine world. I don't really like to change this default behavior ( And I can see that JSP syntax does the same. ) For me, the proper fix is to check non-NULL value before printing if we don't want to write "null". So I prefer to take "Won't Fix" for this. WDYT ?
Trong Tran <trongtt> updated the status of jira GTNPORTAL-2373 to Resolved