Spec URL: http://ankursinha.fedorapeople.org/irssi-notify/irssi-notify.spec SRPM URL: http://ankursinha.fedorapeople.org/irssi-notify/irssi-notify-0.2.0-1.fc17.src.rpm Description: This script issues notifications on the desktop to let a GUI user know something is going on in an Irssi session. The following types of messages produce notifications: - private message - highlighted public message - DCC request Please read the README.txt file provided to learn usage. Fedora Account System Username: ankursinha --------------------------------------------------------------------------- rpmlint output: [ankur@ankur SOURCES]$ rpmlint ../SPECS/irssi-notify.spec ../SRPMS/irssi-notify-0.2.0-1.fc17.src.rpm ../RPMS/noarch/irssi-notify-0.2.0-1.fc17.noarch.rpm ../SPECS/irssi-notify.spec: W: invalid-url Source2: http://irssi-notify.googlecode.com/svn/trunk/README.txt HTTP Error 404: Not Found ../SPECS/irssi-notify.spec: W: invalid-url Source1: http://irssi-notify.googlecode.com/svn/trunk/notify-listener.py HTTP Error 404: Not Found ../SPECS/irssi-notify.spec: W: invalid-url Source0: http://irssi-notify.googlecode.com/svn/trunk/notify.pl HTTP Error 404: Not Found irssi-notify.src: W: spelling-error Summary(en_US) libnotify -> lib notify, lib-notify, notify irssi-notify.src: W: invalid-url URL: http://code.google.com/p/irssi-notify/wiki/ HTTP Error 404: Not Found irssi-notify.src: W: strange-permission notify-listener.py 0640L irssi-notify.src: W: strange-permission notify.pl 0640L irssi-notify.src: W: strange-permission README.txt 0640L irssi-notify.src: W: invalid-url Source2: http://irssi-notify.googlecode.com/svn/trunk/README.txt HTTP Error 404: Not Found irssi-notify.src: W: invalid-url Source1: http://irssi-notify.googlecode.com/svn/trunk/notify-listener.py HTTP Error 404: Not Found irssi-notify.src: W: invalid-url Source0: http://irssi-notify.googlecode.com/svn/trunk/notify.pl HTTP Error 404: Not Found irssi-notify.noarch: E: explicit-lib-dependency libnotify irssi-notify.noarch: W: invalid-url URL: http://code.google.com/p/irssi-notify/wiki/ HTTP Error 404: Not Found 2 packages and 1 specfiles checked; 1 errors, 12 warnings. [ankur@ankur SOURCES]$ It's a comparitively simple package. However, there may be some tiny issues that need fixing.
I'll look at this.
Before I start reviewing: - there's no such project as irssi-notify; did you mean irssi-libnotify? - you really shouldn't point to svn trunk; if upstream doesn't provide release tarballs, make one yourself with a date tag or something - don't provide your own copy of license if upstream doesn't ship it
(In reply to comment #2) > Before I start reviewing: > > - there's no such project as irssi-notify; did you mean irssi-libnotify? > - you really shouldn't point to svn trunk; if upstream doesn't provide > release tarballs, make one yourself with a date tag or something > - don't provide your own copy of license if upstream doesn't ship it Updated spec/srpm with corrections: http://ankursinha.fedorapeople.org/irssi-libnotify/irssi-libnotify.spec http://ankursinha.fedorapeople.org/irssi-libnotify/irssi-libnotify-0.2.0-2.fc17.src.rpm Thanks :) Ankur
Opened a request in the upstream tracker: http://code.google.com/p/irssi-libnotify/issues/detail?id=11 requesting upstream to release tarballs, and to include a license file. Thanks, Ankur
I see your issue was closed as WONTFIX. No tarballs, license file not included. There are no version tags in the git repo either... I suppose the missing license file isn't a blocker in this case (GPLv2+), according to the Licensing Guidelines [1]. If you're still interested in packaging this, we could get this in. [1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
Hi Petr, In the issue I filed, Paul has said that he doesn't think the software is for a general audience. He prefers that people who know what to do set it up manually. It's why I'm not pursuing the review ticket any more. Closing the review ticket as a WONTFIX as well. Thanks, Warm regards, Ankur