Bug 825353 - Application templates have possible security vuln in shared secret session key
Summary: Application templates have possible security vuln in shared secret session key
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Website
Version: 2.x
Hardware: Unspecified
OS: Unspecified
high
low
Target Milestone: ---
: ---
Assignee: Fotios Lindiakos
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-25 19:01 UTC by Clayton Coleman
Modified: 2015-05-15 01:10 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-07 19:20:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Warning for templates (46.36 KB, image/png)
2012-05-31 01:00 UTC, Fotios Lindiakos
no flags Details

Description Clayton Coleman 2012-05-25 19:01:00 UTC
Application templates for wordpress and rails (at a minimum) have hardcoded session secret keys in their configuration that would expose users creating new applications from those templates to session security vulnerabilities unless the developer changes it.

Since we can't safely assume users will change those, the quickstart source we need will have to generate those the first time they are deployed and then read from the file.

Recommend in Rails example the secret_token.rb file attempt to read it from a file in the data dir, and if it doesn't exist,create a new one based on a source of entropy on the system.  

There's a pull request for wordpress from a community member who demonstrates a fix (https://github.com/openshift/wordpress-example/pull/3) - recommend we merge that.

We can't ship application templates that have this vulnerability.  Need to security review all app templates for source.

Comment 1 Clayton Coleman 2012-05-25 19:01:37 UTC
Reach out to the evangelism team (through Grant) to get help fixing the other templates as needed.   Templates can't go live until this is resolved.

Comment 2 Fotios Lindiakos 2012-05-31 01:00:00 UTC
Created attachment 587892 [details]
Warning for templates

Comment 3 Fotios Lindiakos 2012-05-31 01:02:23 UTC
Currently, we are providing the users with a warning banner when creating templates that tells them to check the README file in the git repo for additional information.

Going forward, we will figure out the best way to handle this.

Comment 4 Fotios Lindiakos 2012-06-07 19:20:34 UTC
This has been converted to a User Story, https://rally1.rallydev.com/#/4670513817d/detail/userstory/6600022116.

Closing the bug.


Note You need to log in before you can comment on or make changes to this bug.