Spec URL: https://www.studentrobotics.org/~rspanton/rpm/arm-cortex_m-eabi/arm-cortex_m-eabi-binutils-2.22-1.fc16.src.rpm SRPM URL: https://www.studentrobotics.org/~rspanton/rpm/arm-cortex_m-eabi/arm-cortex_m3-eabi-binutils.spec Description: A cross-compiling version of binutils for ARM Cortex-M platforms. This is the first part of a cross-compiling toolchain for these devices. gcc, newlib, and gdb will follow after this has been reviewed. rpmlint outputs no errors or warnings when presented with the spec. Fedora Account System Username: rspanton
I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. Both URLs are 404 for me.
Hi, These packages are now here: SRPM: https://xgoat.com/~rob/rpm/arm-cortex_m-eabi/arm-cortex_m-eabi-binutils-2.22-1.fc16.src.rpm Spec: https://xgoat.com/~rob/rpm/arm-cortex_m-eabi/arm-cortex_m3-eabi-binutils.spec I intend on updating the package to 2.23.1 soon. I've got somewhat bored of waiting for a review :(
I'll give it a look.
rpmlint on the srpm gives me: arm-cortex_m-eabi-binutils.src: E: description-line-too-long C assemble and link binaries for the arm-cortex_m-eabi platform, instead of for the arm-cortex_m-eabi-binutils.src: E: invalid-spec-name 1 packages and 0 specfiles checked; 2 errors, 0 warnings. And on the rpm: arm-cortex_m-eabi-binutils.armv7hl: E: description-line-too-long C assemble and link binaries for the arm-cortex_m-eabi platform, instead of for the arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/arm-cortex_m-eabi/bin/objcopy /usr/bin/arm-cortex_m-eabi-objcopy arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/arm-cortex_m-eabi/bin/ld.bfd /usr/bin/arm-cortex_m-eabi-ld arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/bin/arm-cortex_m-eabi-ld.bfd /usr/arm-cortex_m-eabi/bin/ld.bfd arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/arm-cortex_m-eabi/bin/nm /usr/bin/arm-cortex_m-eabi-nm arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/arm-cortex_m-eabi/bin/ld /usr/bin/arm-cortex_m-eabi-ld.bfd arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/bin/arm-cortex_m-eabi-objdump /usr/arm-cortex_m-eabi/bin/objdump arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/bin/arm-cortex_m-eabi-strip /usr/arm-cortex_m-eabi/bin/strip arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/bin/arm-cortex_m-eabi-ranlib /usr/arm-cortex_m-eabi/bin/ranlib arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/arm-cortex_m-eabi/bin/as /usr/bin/arm-cortex_m-eabi-as arm-cortex_m-eabi-binutils.armv7hl: W: cross-directory-hard-link /usr/arm-cortex_m-eabi/bin/ar /usr/bin/arm-cortex_m-eabi-ar arm-cortex_m-eabi-binutils.armv7hl: W: no-manual-page-for-binary arm-cortex_m-eabi-ld.bfd arm-cortex_m-eabi-binutils.armv7hl: W: non-standard-dir-in-usr arm-cortex_m-eabi 1 packages and 0 specfiles checked; 1 errors, 12 warnings. rpmlint on the debuginfo rpm gives me: arm-cortex_m-eabi-binutils-debuginfo.armv7hl: E: incorrect-fsf-address /usr/src/debug/arm-cortex_m-eabi-binutils/binutils-2.22/bfd/elf-vxworks.c arm-cortex_m-eabi-binutils-debuginfo.armv7hl: E: incorrect-fsf-address /usr/src/debug/arm-cortex_m-eabi-binutils/binutils-2.22/bfd/elf-vxworks.h 1 packages and 0 specfiles checked; 2 errors, 0 warnings. The version of the license you have listed in the spec is not the same as in COPYING; in COPYING it is GPLv2, spec lists GPLv3+ Are you sure that texinfo is the only build requires? Regular binutils requires quite a bit more Fix the above, and I'll aprove.
Hi John, I've finally got around to dealing with the issues you've raised, and I've updated the version in the process. New spec: https://xgoat.com/~rob/rpm/arm-cortex_m-eabi/arm-cortex_m3-eabi-binutils.spec New SRPM: https://xgoat.com/~rob/rpm/arm-cortex_m-eabi/arm-cortex_m-eabi-binutils-2.24-1.fc20.src.rpm rpmlint will give you some warnings from those, but these are apparently to be expected from cross-compiling things. This thread: https://lists.fedoraproject.org/pipermail/devel/2012-January/160806.html contains someone asking questions about those rpmlint warnings. The warnings from rpmlint fall into the following groups: - cross-directory-hard-link: According to that thread (and other shipping cross-compiling binutils, e.g. avr-binutils), this is OK. - non-standard-dir-in-usr: This is a feature of the cross-compiling toolchain. Again dealt with in that thread, and also following suit on the behaviour of other already shipping cross-compiling binutils packages. The BuildRequires of just texinfo appears to be fine to me. It builds in mock with no problems. Regarding the licence: The sources contain GPL v2+ and v3+. I'm following suit on what the binutils package does, and labelling this as GPLv3+. I assume this is correct. Cheers, Rob
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.