Spec URL: http://beckerde.fedorapeople.org/transifex/python-django-ajax-selects.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/python-django-ajax-selects-1.1.4-1.fc18.src.rpm Description: Enables editing of ForeignKey, ManyToMany and simple text fields using the Autocomplete - jQuery plugin. python-django-ajax-selects will work in any normal form as well as in the admin. The user is presented with a text field. They type a search term or a few letters of a name they are looking for, an ajax request is sent to the server, a search channel returns possible results. Results are displayed as a drop down menu. When an item is selected it is added to a display area just below the text field. Fedora Account System Username: beckerde
I'll take this one.
Some drive by comments: Issues: [!]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 Since we're not targeting anything older than f18, you should delete those statements.
Done. Spec URL: http://beckerde.fedorapeople.org/transifex/python-django-ajax-selects.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/python-django-ajax-selects-1.1.4-2.fc18.src.rpm
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [!]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint python-django-ajax-selects-1.1.4-2.fc18.src.rpm python-django-ajax-selects.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint python-django-ajax-selects-1.1.4-2.fc18.noarch.rpm python-django-ajax-selects.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry python-django-ajax-selects.noarch: W: self-obsoletion django-ajax-selects < 1.1.4-4 obsoletes django-ajax-selects = 1.1.4-2.fc18 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/mrunge/review/825510/django-ajax-selects-1.1.4.tar.gz : MD5SUM this package : 91288063da2b020c34f9ec6c166c25f0 MD5SUM upstream package : 91288063da2b020c34f9ec6c166c25f0 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [!]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [!]: SHOULD Spec use %global instead of %define. Note: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} Issues: [!]: MUST Rpmlint output is silent. rpmlint python-django-ajax-selects-1.1.4-2.fc18.src.rpm python-django-ajax-selects.src: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint python-django-ajax-selects-1.1.4-2.fc18.noarch.rpm python-django-ajax-selects.noarch: W: spelling-error %description -l en_US jQuery -> j Query, query, equerry python-django-ajax-selects.noarch: W: self-obsoletion django-ajax-selects < 1.1.4-4 obsoletes django-ajax-selects = 1.1.4-2.fc18 1 packages and 0 specfiles checked; 0 errors, 2 warnings. - Version 1.2.4 was released on Jan 15th 2012. - you should correct release numbers (this should be number 6, not 2). This version is obsoleting itself, if you update to version 1.2.4, then this problem is gone. - python-django is not required for build - could you please be more specific in files-section?, e.g. %{python_sitelib}/ajax_select (also for the corresponding egg-info)? - you should also remove the first line (%{!?python_sitelib:....) as it's not required any more.
ah, forgot to add: you should note the buildrequirements each in one line. I think, it's more readable. BuildRequirement python-devel should read python2-devel cf. https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
Fixed all the items requested in the last two comments. Spec URL: http://beckerde.fedorapeople.org/transifex/python-django-ajax-selects.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/python-django-ajax-selects-1.2.4-1.fc18.src.rpm Sorry for the delay, I've been bu$i.
OK, thank you, all issues fixed. package is APPROVED.
New Package SCM Request ======================= Package Name: python-django-ajax-selects Short Description: Enables editing of ForeignKey, ManyToMany and simple text fields Owners: beckerde Branches: InitialCC:
Git done (by process-git-requests).