Bug 826014 - Review Request: wsil4j - Web Services Inspection Language for Java API
Summary: Review Request: wsil4j - Web Services Inspection Language for Java API
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Mikolaj Izdebski
QA Contact: Fedora Extras Quality Assurance
Depends On: 825890
Blocks: 827917
TreeView+ depends on / blocked
Reported: 2012-05-29 11:11 UTC by Gerard Ryan
Modified: 2012-06-17 22:27 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-06-17 22:27:30 UTC
Type: ---
mizdebsk: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Gerard Ryan 2012-05-29 11:11:30 UTC
Spec URL: http://galileo.fedorapeople.org/wsil4j-1.0/wsil4j.spec

SRPM URL: http://galileo.fedorapeople.org/wsil4j-1.0/wsil4j-1.0-1.fc17.src.rpm

The Web Services Inspection Language (WS-Inspection) provides a distributed Web
service discovery method, by specifying how to inspect a web site for available
Web services. The WS-Inspection specification defines the locations on a Web
site where you could look for Web service descriptions.

Fedora Account System Username: galileo

Comment 1 Gerard Ryan 2012-06-03 17:36:52 UTC
I've submitted a ticket[0] with rel-eng to get uddi4j included in a build root, so that this can be reviewed more quickly.


Comment 2 Mikolaj Izdebski 2012-06-08 11:23:20 UTC
I'm taking this review.

Comment 3 Gerard Ryan 2012-06-08 11:40:16 UTC
Updated to add zip to BuildRequires.

Spec URL: http://galileo.fedorapeople.org/wsil4j-1.0/1.0-2/wsil4j.spec

SRPM URL: http://galileo.fedorapeople.org/wsil4j-1.0/1.0-2/wsil4j-1.0-2.fc17.src.rpm

Comment 4 Gerard Ryan 2012-06-08 12:29:11 UTC
Added POM & removed xerces-j2 dependency.

SPEC URL: http://galileo.fedorapeople.org/wsil4j-1.0/1.0-3/wsil4j.spec

SRPM URL: http://galileo.fedorapeople.org/wsil4j-1.0/1.0-3/wsil4j-1.0-3.fc17.src.rpm

Comment 5 Gerard Ryan 2012-06-08 12:36:22 UTC
Fully removed xerces-j2 dependency this time!

SPEC: http://galileo.fedorapeople.org/wsil4j-1.0/1.0-4/wsil4j.spec

SRPM: http://galileo.fedorapeople.org/wsil4j-1.0/1.0-4/wsil4j-1.0-4.fc17.src.rpm

Comment 6 Mikolaj Izdebski 2012-06-08 12:58:03 UTC
Package Review

- = N/A
x = Pass
! = Fail
? = Not evaluated

==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: SHOULD Package should compile and build into binary rpms on all supported
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
[x]: SHOULD Spec use %global instead of %define.

==== Java ====
[x]: MUST If source tarball includes bundled jar/class files these need to be
     removed prior to building
[x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Javadoc documentation files are generated and included in -javadoc
[x]: MUST Javadoc subpackages have Requires: jpackage-utils
[x]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version}
[x]: SHOULD Package has BuildArch: noarch (if possible)
[x]: SHOULD Package uses upstream build method (ant/maven/etc.)

==== Maven ====
[x]: MUST Pom files have correct add_maven_depmap call
     Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: MUST Old add_to_maven_depmap macro is not being used
[x]: MUST Packages DOES NOT have Requires(post) and Requires(postun) on
     jpackage-utils for %update_maven_depmap macro
[x]: MUST If package contains pom.xml files install it (including depmaps)
     even when building with ant
[x]: MUST Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: MUST Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

[!]: MUST Rpmlint output is silent.

rpmlint wsil4j-1.0-4.fc18.src.rpm

wsil4j.src: W: invalid-url Source0: wsil4j-1.0.tar.xz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

rpmlint wsil4j-javadoc-1.0-4.fc18.noarch.rpm

wsil4j-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java docs, Java-docs, Avocados
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

rpmlint wsil4j-1.0-4.fc18.noarch.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.

These warnings can be ignored.

Tested on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4140393
Thank you for packaging wsil4j!


Comment 7 Gerard Ryan 2012-06-08 13:08:23 UTC
New Package SCM Request
Package Name: wsil4j
Short Description: Web Services Inspection Language for Java API
Owners: galileo
Branches: f17

Comment 8 Gwyn Ciesla 2012-06-08 13:32:01 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2012-06-08 16:06:17 UTC
wsil4j-1.0-4.fc17 has been submitted as an update for Fedora 17.

Comment 10 Fedora Update System 2012-06-10 01:26:33 UTC
wsil4j-1.0-4.fc17 has been pushed to the Fedora 17 testing repository.

Comment 11 Fedora Update System 2012-06-17 22:27:30 UTC
wsil4j-1.0-4.fc17 has been pushed to the Fedora 17 stable repository.

Note You need to log in before you can comment on or make changes to this bug.