Spec URL: http://rezza.hofyland.cz/fedora/packages/nepomuk-core/nepomuk-core.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/nepomuk-core/nepomuk-core-4.8.80.tar.xz Description: Nepomuk Core utilities and libraries Fedora Account System Username: jreznik
will take a look after kde-sig meeting...
naming: ok sources: ok $ md5sum *.xz db4aa40110903973b8a37bea6b13a974 nepomuk-core-4.8.80.tar.xz 1. License: NOT ok looks like some sources have the standard kde blurb, so we'll likely need to use: # KDE e.V. may determine that future GPL versions are accepted License: GPLv2 or GPLv3 here 2. fix Requires: kdelibs%{?_isa} >= %{version} to be: Requires: kdelibs4%{?_isa} >= %{_kde4_version} instead. 3. for the shlibs, probably ought to make a -libs subpkg, with scriptlets (currently missing); %post libs -p /sbin/ldconfig %postun libs -p /sbin/ldconfig 4. add desktop-file-validate %check desktop-file-validate %{buildroot}%{_kde4_datadir}/applications/kde4/nepomukbackup.desktop Fix those, and we should be good.
Sorry, for point 1, make that s/GPL/LGPL/
(In reply to comment #2) > naming: ok > > sources: ok > $ md5sum *.xz > db4aa40110903973b8a37bea6b13a974 nepomuk-core-4.8.80.tar.xz > > 1. License: NOT ok > looks like some sources have the standard kde blurb, so we'll likely need to > use: > > # KDE e.V. may determine that future GPL versions are accepted > License: GPLv2 or GPLv3 Ok. > here > > > 3. for the shlibs, probably ought to make a -libs subpkg, with scriptlets > (currently missing); > %post libs -p /sbin/ldconfig > %postun libs -p /sbin/ldconfig I wasn't sure we want for a small package libs subpackage, but ok. Oh, I forgot ldconfig... > > 4. add desktop-file-validate > > %check > desktop-file-validate > %{buildroot}%{_kde4_datadir}/applications/kde4/nepomukbackup.desktop Ok. > > Fix those, and we should be good. Thanks.
Spec URL: http://rezza.hofyland.cz/fedora/packages/nepomuk-core/nepomuk-core.spec SRPM URL: http://rezza.hofyland.cz/fedora/packages/nepomuk-core/nepomuk-core-4.8.80-2.fc16.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=4113948 License and requires fixed, -libs split, desktop-file validation added.
Thanks, Approved.
New Package SCM Request ======================= Package Name: nepomuk-core Short Description: Nepomuk Core utilities and libraries Owners: jreznik kkofler rdieter than ltinkl rnovacek Branches: f17 InitialCC:
Git done (by process-git-requests).
imported