Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 827626

Summary: Guvnor bulk importer generates import files with invalid package names under Windows 7
Product: [JBoss] JBoss Enterprise BRMS Platform 5 Reporter: Hao Wu <hwu>
Component: BRM (Guvnor)Assignee: Mark Proctor <mproctor>
Status: CLOSED UPSTREAM QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: BRMS 5.3.0.GACC: rzhang
Target Milestone: ER9   
Target Release: BRMS 5.3.0.GA   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-02-10 03:20:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
test.properties none

Description Hao Wu 2012-06-01 21:45:53 UTC 
Description of problem:
The Guvnor bulk importer generates an import file with invalid package name under Windows.

Version-Release number of selected component (if applicable):
ER8

How reproducible:


Steps to Reproduce:
1. Have a single test.xls file under c:\temp\my_rules\test\pkg\
2. Run in c:\temp: java -jar ../brms-bulk-importer-5.3.0.BRMS-ER8.jar -prop test.properties.  See attachment for test.properties.
3. Look in import.xml
  
Actual results:
The package name is c:\temp\my_rules\test\pkg

Expected results:
The package name should be test.pkg

Additional info:
Fixed in Drools 5.4.  The culprit seems like the getPackageName() method in org.jboss.drools.guvnor.importgenerator.PackageFile.  The regex is wrong in 5.3.
Comment 1 Hao Wu 2012-06-01 21:46:40 UTC 
Created attachment 588585 [details]
test.properties
Comment 2 Ryan Zhang 2012-06-12 09:05:33 UTC 
I think this has been assigned to Jervis, so I update the status.
If no, please feel free to revert it.
ER9 is waiting on this.
Comment 3 Hao Wu 2012-06-12 16:01:55 UTC 
More details:

   1. Basically under windows the package name is not parsed correctly from the path.
    2. I assume the code is using what's in Drools 5.3 so in org.jboss.drools.guvnor.importgenerator.PackageFile, the getPackageName() method is only using "([^/]+)" as the regex.
    3. In Drools 5.4, this is corrected by using "([^/|\\\\]+)" to account for windows path separators.
Comment 4 Jervis Liu 2012-06-12 17:10:57 UTC 
Fxied on 5.3.x.
Comment 5 Ryan Zhang 2012-06-13 09:32:51 UTC 
This issue's fixes  have been picked by ER9. Please verify them on ER9.
Comment 6 Petr Široký 2012-06-19 11:17:29 UTC 
Verified fixed in 5.3.0 ER9 (tested on Win 7 x86_64).
Comment 12 Red Hat Bugzilla 2025-02-10 03:20:02 UTC 
This product has been discontinued or is no longer tracked in Red Hat Bugzilla.