Spec URL: http://salimma.fedorapeople.org/specs/admin/python-ttystatus.spec SRPM URL: http://salimma.fedorapeople.org/specs/admin/python-ttystatus-0.18-1.fc17.src.rpm Description: ttystatus is a Python library for showing progress reporting and status updates on terminals, for (Unix) command line programs. Output is automatically adapted to the width of the terminal: truncated if it does not fit, and re-sized if the terminal size changes. Output is provided via widgets. Each widgets formats some data into a suitable form for output. It gets the data either via its initializer, or from key/value pairs maintained by the master object. The values are set by the user. Every time a value is updated, widgets get updated (although the terminal is only updated every so often to give user time to actually read the output). Fedora Account System Username: salimma
I can look at reviewing this tomorrow unless someone beats me to it. ;) I note that it doesn't seem to build in rawhide mock currently: + make check python -m CoverageTestRunner --ignore-missing-from=without-tests FAILED ... 0 failures, 0 errors 62 excluded statements 5 excluded modules 2 missing test modules Time: 1.4 s make: *** [check] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.58C9Ov (%check)
(In reply to comment #1) > I can look at reviewing this tomorrow unless someone beats me to it. ;) > > I note that it doesn't seem to build in rawhide mock currently: > > + make check > python -m CoverageTestRunner --ignore-missing-from=without-tests > FAILED I need to update the package -- basically my initial packages were created using the CoverageTestRunner version posted on the author's site, which did not actually properly fail when detecting missing tests. The latest one now packaged does, but the tests are meant to run before the build directory is created, whereas our %%check is run after %%build and %%install -- I'll update the srpm to actually wipe build before running tests.
Updated spec and SRPM. Thanks, Kevin, for noticing the issue. Spec URL: http://salimma.fedorapeople.org/specs/admin/python-ttystatus.spec SRPM URL: http://salimma.fedorapeople.org/specs/admin/python-ttystatus-0.18-2.fc17.src.rpm
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv3+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 7e7d507a77db43a285f1a1e17d09b4c3 python-ttystatus_0.18.orig.tar.gz 7e7d507a77db43a285f1a1e17d09b4c3 python-ttystatus_0.18.orig.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: python-ttystatus.noarch: W: spelling-error %description -l en_US initializer -> initialize, initializes, initialized python-ttystatus.src: W: spelling-error %description -l en_US initializer -> initialize, initializes, initialized 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Can be ignored. I see no blockers here, so this package is APPROVED.
Thanks, Kevin! New Package SCM Request ======================= Package Name: python-ttystatus Short Description: Progress and status updates on terminals for Python Owners: salimma Branches: f16 f17 InitialCC:
Git done (by process-git-requests).
python-ttystatus-0.18-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-ttystatus-0.18-2.fc16
python-ttystatus-0.18-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-ttystatus-0.18-2.fc17
python-ttystatus-0.18-2.fc17 has been pushed to the Fedora 17 testing repository.
python-ttystatus-0.18-2.fc16 has been pushed to the Fedora 16 stable repository.
python-ttystatus-0.18-2.fc17 has been pushed to the Fedora 17 stable repository.
Package Change Request ====================== Package Name: python-cliapp New Branches: el6
Package Change Request ====================== Package Name: python-ttystatus New Branches: el6
Misformatted request.
Package Change Request ====================== Package Name: python-ttystatus New Branches: el6 Owners: salimma