Spec URL: http://omicron.mifo.sk/rpms/rubygem-sinatra-rabbit.spec SRPM URL: http://omicron.mifo.sk/rpms/rubygem-sinatra-rabbit-1.0.6-1.fc17.src.rpm Description: Sinatra::Rabbit is a Sinatra extensions that makes designing a REST API much easier and more fun. Rabbit maps REST resources to 'collections'. Every collection then could define CRUD and other operations to manipulate with resource. Rabbit will handle parameter validation and capability checks for you, so you can focus on the structure and design of your REST API. Fedora Account System Username: mfojtik
* Mon Jun 04 2012 Michal Fojtik <mfojtik> 1.0.6-2 - Added exclude tag before gem_cache - Removed the ruby dependency Spec URL: http://omicron.mifo.sk/rpms/rubygem-sinatra-rabbit.spec SRPM URL: http://omicron.mifo.sk/rpms/rubygem-sinatra-rabbit-1.0.6-2.fc17.src.rpm
I'll take it for a review.
* Please consider running test in %{_builddir} - Could you consider to run test suite in %{_builddir} instead of %{buildroot}? I.e. use "pushd .%{gem_instdir}" in %check section. In my experience, it may prevent pollution of the resulting package by some temporary dirs/files. * Use %exclude instead of rm - You might consider to use %exclude in files section instead of rm in %install section. This is just a hint. * I am not expert on Sinatra, but this doesn't look good: # irb irb(main):001:0> require 'sinatra/rabbit' NameError: uninitialized constant Sinatra from /usr/share/gems/gems/sinatra-rabbit-1.0.6/lib/sinatra/rabbit.rb:33:in `<top (required)>' from /usr/share/rubygems/rubygems/custom_require.rb:60:in `require' from /usr/share/rubygems/rubygems/custom_require.rb:60:in `rescue in require' from /usr/share/rubygems/rubygems/custom_require.rb:35:in `require' from (irb):1 from /usr/bin/irb:12:in `<main>' Nevertheless, this is probably not a real life problem, so it is not blocking the review. Overall, the package looks good and all the issues mentioned above are just minor nits => APPROVED
Thanks Vit! Since it's a Sinatra extension, you need to have 'sinatra/base' required first before you require this extension. Probably a good point to add some additional treating for errors like this. I'll fix all things above.
New Package SCM Request ======================= Package Name: rubygem-sinatra-rabbit Short Description: Ruby DSL for creating restful applications using Sinatra Owners: mfojtik Branches: f16 f17 el6 InitialCC: mfojtik
Git done (by process-git-requests).
rubygem-sinatra-rabbit-1.0.6-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-sinatra-rabbit-1.0.6-2.fc16
rubygem-sinatra-rabbit-1.0.6-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-sinatra-rabbit-1.0.6-2.fc17
rubygem-sinatra-rabbit-1.0.6-2.fc16 has been pushed to the Fedora 16 testing repository.
rubygem-sinatra-rabbit-1.0.6-2.fc17 has been pushed to the Fedora 17 stable repository.
rubygem-sinatra-rabbit-1.0.6-2.fc16 has been pushed to the Fedora 16 stable repository.