Bug 828444 - Review Request: drupal6-context_menu_block - Context Menu Block Module for Drupal6
Summary: Review Request: drupal6-context_menu_block - Context Menu Block Module for Dr...
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On: 828458
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-04 18:14 UTC by Anderson Silva
Modified: 2013-04-01 22:23 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2013-04-01 22:22:55 UTC
shawn: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
drupal6-context_menu_block-review.txt (6.32 KB, text/plain)
2013-02-27 23:08 UTC, Shawn Iwinski
no flags Details
phpci.log (9.69 KB, text/x-log)
2013-02-27 23:08 UTC, Shawn Iwinski
no flags Details

Description Anderson Silva 2012-06-04 18:14:40 UTC
Spec URL: http://people.redhat.com/~ansilva/drupal6-context_menu_block.spec
SRPM URL: http://people.redhat.com/~ansilva/drupal6-context_menu_block-3.0-2.fc16.src.rpm
Description: Allows the Menu Block module to be aware of contexts provided by the Context module.
Fedora Account System Username: afsilva

Comment 1 Shawn Iwinski 2013-02-26 02:24:45 UTC
Wesley -- Do you plan on completing this review?  If not, I can take it.  Shawn

Comment 2 Shawn Iwinski 2013-02-27 23:08:23 UTC
Created attachment 703710 [details]
drupal6-context_menu_block-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 828444

Comment 3 Shawn Iwinski 2013-02-27 23:08:52 UTC
Created attachment 703711 [details]
phpci.log

Comment 4 Shawn Iwinski 2013-02-27 23:11:24 UTC
===== SHOULD items =====

> [!]: Package does not include license text files separate from upstream.

I believe this is because of a license update in the actual license file?  Has upstream been made aware of the needed update?

> [!]: Packages should try to preserve timestamps of original installed files.

Please consider adding the "-p" (or "--preserve-timestamps") flag to your install command.


Per phpci, after initial import, please add "php-pcre" requirement.



No blockers.

===== APPROVED =====

Comment 5 Anderson Silva 2013-03-22 16:05:36 UTC
New Package SCM Request
=======================
Package Name: drupal6-context_menu_block
Short Description: Allows the Menu Block module to be aware of contexts provided by the Context module
Owners: ansilva mwoodson siwinski
Branches: f17 f18 f19 el6
InitialCC:

Comment 6 Gwyn Ciesla 2013-03-22 16:08:58 UTC
"ansilva" is not a valid FAS account.

Comment 7 Anderson Silva 2013-03-22 16:29:05 UTC
I hate when i do this... I used my red hat user instead of my fedora.. I am removing mwoodson too:

New Package SCM Request
=======================
Package Name: drupal6-context_menu_block
Short Description: Allows the Menu Block module to be aware of contexts provided by the Context module
Owners: afsilva siwinski
Branches: f17 f18 f19 el6
InitialCC:

Comment 8 Gwyn Ciesla 2013-03-22 18:19:03 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2013-03-22 21:31:30 UTC
drupal6-context_menu_block-3.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal6-context_menu_block-3.0-2.el6

Comment 10 Fedora Update System 2013-03-22 21:32:08 UTC
drupal6-context_menu_block-3.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/drupal6-context_menu_block-3.0-2.fc17

Comment 11 Fedora Update System 2013-03-22 21:32:50 UTC
drupal6-context_menu_block-3.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/drupal6-context_menu_block-3.0-2.fc18

Comment 12 Shawn Iwinski 2013-03-23 04:53:15 UTC
Package Change Request
======================
Package Name: drupal6-context_menu_block
New Branches: el5
Owners: ansilva siwinski
InitialCC: 

Adding el5 branch to follow most other drupal6 packages.

Comment 13 Gwyn Ciesla 2013-03-23 13:03:21 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2013-03-23 18:16:32 UTC
drupal6-context_menu_block-3.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 15 Fedora Update System 2013-04-01 22:22:56 UTC
drupal6-context_menu_block-3.0-2.fc17 has been pushed to the Fedora 17 stable repository.

Comment 16 Fedora Update System 2013-04-01 22:23:32 UTC
drupal6-context_menu_block-3.0-2.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.