Description of problem: The default template uses the expanded definition instead of %make_install. Details at https://fedorahosted.org/fpc/ticket/183. You can wait till the draft is approved before making this change if you prefer.
I don't think changing to use that would be an improvement at the moment. The vast majority of Fedora packages use the expanded definition anyway, and starting to use the macro would create an unnecessary incompatibility with rpm < 4.8.0 (EPEL 5).
I think you should change the template based on which os it is being run from. This also applies to %clean etc for example.
Not based on that, but based on what -r/--rpm-version is set to. Since we do have this feature after all, done upstream: http://git.fedorahosted.org/git/?p=rpmdevtools.git;a=commitdiff;h=9f4736665d84ee683565532fa52a31e695252d87
Thank you so much.
Note that the comment is wrong. you are using %make_install and not %makeinstall.
Fixed, thanks.
rpmdevtools-8.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rpmdevtools-8.3-1.fc18
rpmdevtools-8.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rpmdevtools-8.3-1.fc17
rpmdevtools-8.3-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rpmdevtools-8.3-1.fc16
Package rpmdevtools-8.3-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rpmdevtools-8.3-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-13208/rpmdevtools-8.3-1.fc18 then log in and leave karma (feedback).
rpmdevtools-8.3-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
rpmdevtools-8.3-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.
rpmdevtools-8.3-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.