Red Hat Bugzilla – Bug 828531
remote-viewer.desktop does not validate
Last modified: 2013-12-16 14:17:50 EST
Description of problem:
/usr/share/applications/remote-viewer.desktop is not a valid menu file:
1. It lacks categories so it shows up under "Other" in the menu.
2. It does not validate (which should be done in the spec file according to our packaging guidelines):
$ desktop-file-validate /usr/share/applications/remote-viewer.desktop
/usr/share/applications/remote-viewer.desktop: error: value "False" for boolean key "Terminal" in group "Desktop Entry" contains invalid characters, boolean values must be "false" or "true"
/usr/share/applications/remote-viewer.desktop: error: value "x-scheme-handler/spice" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
Version-Release number of selected component (if applicable):
diff -u remote-viewer.desktop.orig remote-viewer.desktop
--- remote-viewer.desktop.orig 2012-05-16 14:30:01.000000000 +0200
+++ remote-viewer.desktop 2012-06-04 22:42:46.743509473 +0200
@@ -2,5 +2,6 @@
Thanks for the patch, was just gonna forward it upstream but someone got to it just last week:
Author: Doug Goldstein <email@example.com>
Date: Tue Dec 4 16:23:03 2012 -0600
Make .desktop file comply with spec
The .desktop file did not comply with the Desktop Entry spec as checked
with desktop-file-validate. Boolean keys are defined as taking only
'true' or 'false', the entry Terminal had False. MimeType is a string
list and therefore must be terminated with a ;
Since this is fairly minor (AIUI there isn't much functional impact), closing as UPSTREAM.
This issue is still present in F18:
# cat /usr/share/applications/remote-viewer.desktop
# rpm -q virt-viewer
F18 is end-of-life soon, so this bug is unlikely to be fixed there. It should already be fixed in F19 though, so closing.