Bug 829037

Created attachment 589630 [details]
engine log

Description of problem:
Bridgeless network are never being cleanup by VDSM.
using both SetupNetworks or the old Add network way to override an old bridgeless network over the same interface. VDSM will add the new network but won't remove the old bridgeless network. 
It will cause later problems when trying to reconfigure the old bridgeless network: ConfigNetworkError: (28, 'Bridge already exists').

I have added two bridgeless networks over the same interface (one after one. sw2 and sw3) then override this interface with bridged (sw4) network.

the results are:
[root@silver-vdsa ~]# virsh -r net-list --all
Name                 State      Autostart
-----------------------------------------
vdsm-rhevm           active     yes       
vdsm-sw2             active     yes       
vdsm-sw3             active     yes       
vdsm-sw4             active     yes       
default              inactive   no 

[root@silver-vdsa ~]# vdsClient 0 getVdsCaps |grep sw4 --color
        networks = {'rhevm': {'addr': '10.35.128.10', 'cfg': {'DELAY': '0', 'NM_CONTROLLED': 'no', 'BOOTPROTO': 'dhcp', 'DEVICE': 'rhevm', 'TYPE': 'Bridge', 'ONBOOT': 'yes'}, 'mtu': '1500', 'netmask': '255.255.255.0', 'stp': 'off', 'bridged': True, 'gateway': '10.35.128.254', 'ports': ['eth0']}, 'sw3': {'interface': 'eth1', 'bridged': False}, 'sw2': {'interface': 'eth1', 'bridged': False}, 'sw4': {'addr': '', 'cfg': {'DEVICE': 'sw4', 'DELAY': '0', 'TYPE': 'Bridge', 'ONBOOT': 'yes', 'NM_CONTROLLED': 'no'}, 'mtu': '9000', 'netmask': '', 'stp': 'off', 'bridged': True, 'gateway': '0.0.0.0', 'ports': ['eth1']}}



As you can see, VDSM configured sw2, sw3 and sw4 over the same interface.

The Blocker issue is when trying to reconfigure the old bridgeless network:
MainProcess|Thread-16544::ERROR::2012-06-05 22:31:55,420::supervdsmServer::60::SuperVdsm.ServerCallback::(wrapper) Error in editNetwork
Traceback (most recent call last):
  File "/usr/share/vdsm/supervdsmServer.py", line 58, in wrapper
    return func(*args, **kwargs)
  File "/usr/share/vdsm/supervdsmServer.py", line 102, in editNetwork
    return configNetwork.editNetwork(oldBridge, newBridge, **options)
  File "/usr/share/vdsm/configNetwork.py", line 783, in editNetwork
    addNetwork(newBridge, vlan=vlan, bonding=bonding, nics=nics, configWriter=configWriter, **options)
  File "/usr/share/vdsm/configNetwork.py", line 590, in addNetwork
    bridged=bridged, skipLibvirt=skipLibvirt)
  File "/usr/share/vdsm/configNetwork.py", line 503, in _addNetworkValidation
    raise ConfigNetworkError(ne.ERR_USED_BRIDGE, 'Bridge already exists')
ConfigNetworkError: (28, 'Bridge already exists')
Thread-16544::ERROR::2012-06-05 22:31:55,421::API::1209::vds::(editNetwork) Bridge already exists
Traceback (most recent call last):
  File "/usr/share/vdsm/API.py", line 1207, in editNetwork
    supervdsm.getProxy().editNetwork(oldBridge, newBridge, options)
  File "/usr/share/vdsm/supervdsm.py", line 59, in __call__
    return callMethod()
  File "/usr/share/vdsm/supervdsm.py", line 57, in <lambda>
    callMethod = lambda : getattr(self._supervdsmProxy._svdsm, self._funcName)(*args, **kwargs)
  File "<string>", line 2, in editNetwork
  File "/usr/lib64/python2.6/multiprocessing/managers.py", line 740, in _callmethod
    raise convert_to_error(kind, result)
ConfigNetworkError: (28, 'Bridge already exists')


BTW, running vdsClient delNetwork <bridgeless net> directly on the host will clean the network from libvirt.


Steps to Reproduce:
1. create bridgeless network and attach to host eth1
2. create bridged network nad attach to host eth1
3. try to reconfigure the old bridgeless network on eth1
  
Actual results:
libvirt will still contain the old bridgeless network
and the operation will fail due to 'Bridge already exists'

Expected results:
override bridgeless network should remove the network before adding a newer one on the same interface.

Additional info: