Bug 829714 - Review Request: drupal6-imagecache - Image Cache module for drupal6
Summary: Review Request: drupal6-imagecache - Image Cache module for drupal6
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 829067
Blocks: 829718
TreeView+ depends on / blocked
 
Reported: 2012-06-07 11:48 UTC by Anderson Silva
Modified: 2014-02-16 11:24 UTC (History)
4 users (show)

Fixed In Version: drupal6-imagecache-2.0-6.rc1.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-01 22:23:40 UTC
Type: ---
Embargoed:
shawn: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
drupal6-imagecache-review.txt (7.51 KB, text/plain)
2013-02-24 06:35 UTC, Shawn Iwinski
no flags Details
phpci.log (27.75 KB, text/x-log)
2013-02-24 06:36 UTC, Shawn Iwinski
no flags Details

Description Anderson Silva 2012-06-07 11:48:32 UTC
Spec URL: http://people.redhat.com/~ansilva/drupal6-imagecache.spec
SRPM URL: http://people.redhat.com/~ansilva/drupal6-imagecache-2.0-4.rc1.fc16.src.rpm
Description: ImageCache allows you to setup presets for image processing.
Fedora Account System Username: afsilva

Comment 1 Shawn Iwinski 2013-02-24 06:35:56 UTC
Created attachment 701900 [details]
drupal6-imagecache-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 829714

Comment 2 Shawn Iwinski 2013-02-24 06:36:19 UTC
Created attachment 701901 [details]
phpci.log

Comment 3 Shawn Iwinski 2013-02-24 06:41:18 UTC
> [!]: Package installs properly.

This will be resolved by drupal6-imageapi (bug 829067).

> [!]: If (and only if) the source package includes the text of the license(s)
>      in its own file, then that file, containing the text of the license(s)
>      for the package is included in %doc.
>      Note: Cannot find LICENSE.txt in rpm(s)

MUST: Add LICENSE.txt to %doc


===== SHOULD items =====

> [!]: Packages should try to preserve timestamps of original installed files.

Please consider adding the "-p" (or "--preserve-timestamps") flag to your install command.



Per phpci, please add "php-date" and "php-pcre" requirements.

Comment 5 Shawn Iwinski 2013-03-22 19:29:17 UTC
17c17
< Release: 4.rc1%{?dist}
---
> Release: 5.rc1%{?dist}
26c26
< Requires:  drupal6, drupal6-imageapi
---
> Requires:  drupal6, drupal6-imageapi, php-date, php-pcre
40c40
< install -d %{buildroot}%{drupal_modules}/%{modname}
---
> install -p -d %{buildroot}%{drupal_modules}/%{modname}
48d47
< # Remember to include other documentation text here as well
50c49
< # Remember to exclude all documentation texts from above
---
> %doc %{drupal_modules}/%{modname}/LICENSE.txt
51a51
> %exclude %{drupal_modules}/%{modname}/LICENSE.txt
54a55,58
> * Fri Mar 22 2013 Anderson Silva <ansilva> - 2.0-5.rc1
> - Add LICENSE.txt
> - Add php-date, php-pcre requirements
> 


All issues fixed.  No blockers.


===== APPROVED =====

Comment 6 Anderson Silva 2013-03-22 21:24:06 UTC
New Package SCM Request
=======================
Package Name: drupal6-imagecache
Short Description: ImageCache allows you to setup presets for image processing.
Owners: afsilva siwinski
Branches: f17 f18 f19 el6
InitialCC:

Comment 7 Shawn Iwinski 2013-03-23 04:44:05 UTC
Slight modification to include el5.


New Package SCM Request
=======================
Package Name: drupal6-imagecache
Short Description: ImageCache allows you to setup presets for image processing.
Owners: afsilva siwinski
Branches: f17 f18 f19 el5 el6
InitialCC:

Comment 8 Gwyn Ciesla 2013-03-23 13:14:08 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2013-03-23 15:08:12 UTC
drupal6-imagecache-2.0-5.rc1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal6-imagecache-2.0-5.rc1.el6

Comment 10 Fedora Update System 2013-03-23 15:11:15 UTC
drupal6-imagecache-2.0-5.rc1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/drupal6-imagecache-2.0-5.rc1.fc17

Comment 11 Fedora Update System 2013-03-23 15:11:44 UTC
drupal6-imagecache-2.0-5.rc1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/drupal6-imagecache-2.0-5.rc1.fc18

Comment 12 Fedora Update System 2013-03-23 18:18:07 UTC
drupal6-imagecache-2.0-5.rc1.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 13 Fedora Update System 2013-04-01 22:23:43 UTC
drupal6-imagecache-2.0-5.rc1.fc17 has been pushed to the Fedora 17 stable repository.

Comment 14 Fedora Update System 2013-04-01 22:33:09 UTC
drupal6-imagecache-2.0-5.rc1.fc18 has been pushed to the Fedora 18 stable repository.

Comment 15 Fedora Update System 2014-01-26 19:26:27 UTC
drupal6-imagecache-2.0-6.rc1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/drupal6-imagecache-2.0-6.rc1.fc20

Comment 16 Fedora Update System 2014-01-26 19:26:43 UTC
drupal6-imagecache-2.0-6.rc1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal6-imagecache-2.0-6.rc1.el6

Comment 17 Fedora Update System 2014-01-26 19:26:58 UTC
drupal6-imagecache-2.0-6.rc1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/drupal6-imagecache-2.0-6.rc1.el5

Comment 18 Fedora Update System 2014-01-26 19:27:08 UTC
drupal6-imagecache-2.0-6.rc1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/drupal6-imagecache-2.0-6.rc1.fc19

Comment 19 Volker Fröhlich 2014-01-27 18:18:18 UTC
*** Bug 656179 has been marked as a duplicate of this bug. ***

Comment 20 Fedora Update System 2014-02-06 03:47:21 UTC
drupal6-imagecache-2.0-6.rc1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 21 Fedora Update System 2014-02-06 03:54:24 UTC
drupal6-imagecache-2.0-6.rc1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 22 Fedora Update System 2014-02-16 11:23:52 UTC
drupal6-imagecache-2.0-6.rc1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 23 Fedora Update System 2014-02-16 11:24:23 UTC
drupal6-imagecache-2.0-6.rc1.el5 has been pushed to the Fedora EPEL 5 stable repository.


Note You need to log in before you can comment on or make changes to this bug.