RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 830051 - [Doc] virsh doc has error/omission on device commands and nodedev commands
Summary: [Doc] virsh doc has error/omission on device commands and nodedev commands
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.3
Hardware: x86_64
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Michal Privoznik
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-08 05:29 UTC by weizhang
Modified: 2013-02-21 07:16 UTC (History)
6 users (show)

Fixed In Version: libvirt-0.9.13-3.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-21 07:16:43 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2013:0276 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2013-02-20 21:18:26 UTC

Description weizhang 2012-06-08 05:29:02 UTC 
Description of problem:
When review man virsh doc for device commands and nodedev commands, find some problems
1. attach-disk parameter "type" in virsh doc said that "type can indicate cdrom or floppy as alternative to the disk default", omit another allowed type "lun"
2. attach-disk parameter "target" in virsh doc said that "source and target are paths for the files and devices.", the target should be the logical device name, but not path
3. For attach-device, detach-device, detach-disk, detach-interface, omit list parameter --persistent in virsh doc

Version-Release number of selected component (if applicable):
libvirt-0.9.10-21.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.man virsh, and find the device and nodedev commands part
  
Actual results:


Expected results:


Additional info:
Comment 1 weizhang 2012-06-08 07:02:44 UTC 
Also, for attach-interface libvirt will ignore the target name which begin with vnet, I think it should be mentioned in man page
Comment 2 Michal Privoznik 2012-06-18 11:29:40 UTC 
I've proposed patch:

https://www.redhat.com/archives/libvir-list/2012-June/msg00717.html

Except --persistent which is just an alias to --config. Users are advised to use the new --config therefore we don't want to expose --persistent much:

https://www.redhat.com/archives/libvir-list/2012-March/msg00277.html

Therefore I am moving this to POST.
Comment 3 Michal Privoznik 2012-06-18 13:24:22 UTC 
Pushed upstream:

commit cc75fcc90f60940a4979d15ff61396393aa3f0b6
Author:     Michal Privoznik <mprivozn>
AuthorDate: Mon Jun 18 13:14:49 2012 +0200
Commit:     Michal Privoznik <mprivozn>
CommitDate: Mon Jun 18 13:14:49 2012 +0200

    virsh: Tweak attach-* documentation
    
    as we are missing:
    attach-disk: --type can accept 'lun' too, not just cdrom or floppy.
    attach-disk: --target specify logical device name, not path
    attach-interface: --target silently drops strings with vnet* prefix
Comment 6 yuping zhang 2012-07-24 06:12:41 UTC 
Verified this issue with:
libvirt-client-0.9.13-3.el6.x86_64
libvirt-0.9.13-3.el6.x86_64
libvirt-python-0.9.13-3.el6.x86_64

#man virsh
1.attach-disk
...
 target controls the bus or device under which the disk is exposed to the guest OS. It indicates the "logical" device name.
...
type can indicate lun, cdrom or floppy as alternative to thedisk default, although this use only replaces the media within the existing virtual cdrom or floppy device; 
...

2.attach-device, detach-device, detach-disk, detach-interface
...
 For compatibility purposes, --persistent is an alias of --config. 
...

3.For attach-interface 
...
 target allows to indicate the target device in the guest. Names starting with ’vnet’ are considered as auto-generated an hence blanked out. 
...

So change the bug status to VERIFIED.
Comment 7 errata-xmlrpc 2013-02-21 07:16:43 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html
Note You need to log in before you can comment on or make changes to this bug.