Spec URL: http://england/chris/rootfs-resize/rootfs-resize.spec SRPM URL: http://england/chris/rootfs-resize/rootfs-resize-0.1-1.fc16.src.rpm Description: rootfs-resize is a root partition and file system re-sizing service for ARM systems running from SD cards. Fedora Account System Username: ctyler rpmlint output: $ rpmlint rootfs-resize.spec ../SRPMS/rootfs-resize-0.1-1.fc16.src.rpm ../RPMS/noarch/rootfs-resize-0.1-1.fc16.noarch.rpm rootfs-resize.noarch: W: hidden-file-or-dir /.nofsresize rootfs-resize.noarch: W: hidden-file-or-dir /.rootfs-resize rootfs-resize.noarch: W: hidden-file-or-dir /.rootfs-repartition rootfs-resize.noarch: W: no-manual-page-for-binary rootfs-resize 2 packages and 1 specfiles checked; 0 errors, 4 warnings.
I'm taking this one ...
Hi Chris. The links are not reachable from here. Both URLs have to be placed to a publicly reachable server, usually fedorapeople.org. Please fix that and let me know. Jaromir.
Sorry, forgot to use FQDNs: Spec URL: http://england.proximity.on.ca/chris/rootfs-resize/rootfs-resize.spec SRPM URL: http://england.proximity.on.ca/chris/rootfs-resize/rootfs-resize-0.1-1.fc16.src.rpm
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [!]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [-]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: The package did not built BR could therefore not be checked or the package failed to build because of missing BR [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [-]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [!]: MUST Package consistently uses macros (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [!]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint output is silent. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. MD5SUM this package : 6f097c6686d9dc8bf6439759051ec712 MD5SUM upstream package : 6f097c6686d9dc8bf6439759051ec712 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Scriptlets must be sane, if used. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Note: The rootfs-resize script header doesn't contain the GPLv2+ license statement See: None [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST Package consistently uses macros (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros [!]: MUST Package obeys FHS, except libexecdir and /usr/target. Note: The rootfs-resize script interpreter doesn't follow the "UsrMove" (#!/bin/bash -> #!/usr/bin/bash) See: None Final notes: 1. Please, remove all whitespaces at the end of lines (spec file) 2. Since the script can technically run on any architecture, it would be wiser to change the package summary and description to something more generic (architecture independent). We don't want to exclude any architectures unless there's really no way to make the software running on them. Generated by fedora-review 0.1.3 External plugins:
Thanks, Jaromír. I've addressed the issues identified. Updated spec/srpm: Spec URL: http://england/chris/rootfs-resize/rootfs-resize.spec SRPM URL: http://england/chris/rootfs-resize/rootfs-resize-0.2-1.fc16.src.rpm
And once more, with FQDNs: Spec URL: http://england.proximity.on.ca/chris/rootfs-resize/rootfs-resize.spec SRPM URL: http://england.proximity.on.ca/chris/rootfs-resize/rootfs-resize-0.2-1.fc16.src.rpm
And now with shinier script headers: Spec URL: http://england.proximity.on.ca/chris/rootfs-resize/rootfs-resize.spec SRPM URL: http://england.proximity.on.ca/chris/rootfs-resize/rootfs-resize-0.3-1.fc16.src.rpm
[x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package obeys FHS, except libexecdir and /usr/target. === Final Notes === 1. Please, fix the version in the script header and README ================ *** APPROVED *** ================
New Package SCM Request ======================= Package Name: rootfs-resize Short Description: Root partition re-sizing service for SD cards Owners: ctyler Branches: f17 InitialCC:
Git done (by process-git-requests).
rootfs-resize-0.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rootfs-resize-0.3-2.fc17
rootfs-resize-0.3-2.fc17 has been pushed to the Fedora 17 testing repository.
rootfs-resize-0.9-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rootfs-resize-0.9-1.fc18
rootfs-resize-0.9-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rootfs-resize-0.9-1.fc17
rootfs-resize-0.9-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.