Red Hat Bugzilla – Bug 830539
webadmin [Import More than Once]: when importing the vm to a different DC we get a wrong warning in UI
Last modified: 2015-06-19 01:20:56 EDT
Created attachment 590745 [details]
Description of problem:
when I import a vm to a different DC (vm created in NFS and importing more then once to an iscsi DC) we get an exclimation mark on the vm with the following warning:
Use a separate import operation for the marked VMs or Apply "Collapse Snapshots" for all VMs
***the collaps snapshot is automatically marked btw***
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. create nfs domain and create a vm -> expor the vm
2. create iscsi domain and import the vm that was created in nfs from the export domain
we get an highlated unrelated warning
we should not get this error
Additional info:screen shot
Einav, what is the new logic of showing this warning message?
This warning message appears when attempting to import VMs with (thinly-provisioned) disks that have RAW volume-format to an iSCSI storage domain.
Import can be done only if the volume-format of the disks is converted from RAW to COW, and it cannot be done unless collapsing the snapshots of the imported VM.
We implemented this warning "mechanism" in rhev-m 3.0.
Andrew: I see that you acked this BZ; has something changed since rhev-m 3.0 in that sense? Any chance that this message isn't needed anymore?
to my understanding, we only support collaps snapshot for "import more than once" hence the collaps is automatically checked when the vm already exists.
so if this warning is needed we for other cases we should just fix the code to not show the warning when collaps is checked.
(In reply to comment #3)
> to my understanding, we only support collaps snapshot for "import more than
> once" hence the collaps is automatically checked when the vm already exists.
Not exactly: It is the other way around: "import more than once" is supported only with "collapse snapshots" - this is why when importing more than once, the "collapse snapshots" is automatically checked.
"Collapse snapshots" is supported also for importing "regularly", as is, i.e. not "more than once" (check rhev-m 3.0, for example, in which we didn't have "import more than once" at all).
Moreover, the case that I detailed in comment #2 is supported *only* with "collapse snapshots", and it has nothing to do with "import more than once" - I am talking about a regular, "as is" import here.
> so if this warning is needed we for other cases we should just fix the code
> to not show the warning when collaps is checked.
Dafna, according to my explanation above: Can this bug be closed?
> Dafna, according to my explanation above: Can this bug be closed?
if collapse snapshot is marked as default when we import more than once than this warning should not appear.
keeping this error when collapse is checked and greyed out is confusing to the user.
indeed - this warning message should appear only when the check-box is enabled *and un-checked*. In this case it is disabled and checked, therefore no reason to display it.
This message should either be removed, or a different explanation should appear in order to explain why the "Collapse Snapshots" check-box is checked and disabled (not a must IMO - removing the warning should be enough).
Also, the exclamation marks next to the items in the grid should probably be removed as well, or have a correct tool-tip.
*** Note: This is about a scenario in which *all* VMs in the Import dialog either:
1. already exist in the system, or:
2. have thinly-provisioned disks with RAW volume-format, being imported to an iSCSI storage domain.
[If we have one VM (or more) within the Import dialog that neither #1 nor #2 are applicable for it, the "Collapse Snapshots" check-box should be enabled and un-checked with the relevant warning. Once checked, the warning should disappear]
Note that things might change a bit once Bug 840280 is solved - need to follow.
pushed upstream (http://gerrit.ovirt.org/#/c/7313/)
fixed upstream (http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=af9b44d32230893f95091fecdbe65fbca72c16d8)
merged downstream (https://gerrit.eng.lab.tlv.redhat.com/gitweb?p=ovirt-engine.git;a=commit;h=825980d3686bc5258342dd2075964a8f077deedd)
Verified on RHEVM 3.1 - SI17
QEMU & KVM: qemu-kvm-rhev-0.12.1.2-2.295.el6_3.2.x86_64