Bug 830709 - Review Request: robert-hooke - Extension mechanism for Clojure functions
Summary: Review Request: robert-hooke - Extension mechanism for Clojure functions
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 830714 830784
TreeView+ depends on / blocked
Reported: 2012-06-11 09:30 UTC by Michel Alexandre Salim
Modified: 2012-06-30 22:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2012-06-30 22:04:12 UTC
Type: ---
lemenkov: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Michel Alexandre Salim 2012-06-11 09:30:55 UTC
Spec URL: http://salimma.fedorapeople.org/specs/clojure/robert-hooke.spec
SRPM URL: http://salimma.fedorapeople.org/specs/clojure/robert-hooke-1.2.0-1.fc17.src.rpm
Robert Hooke provides a flexible, composable mechanism by which you
can extend behavior of functions after they've been defined. It's
named after Robert Hooke FRS, a founding member of the Royal Society
who made many important discoveries in the fields of Gravitation,
Microscopy, and Astronomy.

Fedora Account System Username: salimma

Comment 1 Michel Alexandre Salim 2012-06-11 15:31:38 UTC
Not ready yet - building with Maven yields an empty JAR

Comment 2 Michel Alexandre Salim 2012-06-11 16:31:40 UTC
Spec URL: http://salimma.fedorapeople.org/specs/clojure/robert-hooke.spec
SRPM URL: http://salimma.fedorapeople.org/specs/clojure/robert-hooke-1.2.0-2.fc17.src.rpm

Now packaged using scriptlet borrowed from upstream's Debian branch

Comment 3 Peter Lemenkov 2012-06-19 11:36:14 UTC
I'll review it.

Comment 4 Peter Lemenkov 2012-06-19 12:19:55 UTC
Koji scratchbuild for Rawhide:

* http://koji.fedoraproject.org/koji/taskinfo?taskID=4176543


Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is almost silent

work ~/Desktop: rpmlint robert-hooke-1.2.0-2.fc18.*
robert-hooke.noarch: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
robert-hooke.src: W: spelling-error %description -l en_US composable -> compo sable, compo-sable, compos able
robert-hooke.src: W: invalid-url Source0: technomancy-robert-hooke-1.1.2-18-g30d2f8f.tar.gz
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
work ~/Desktop: 

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines ( http://fedoraproject.org/wiki/Packaging:Java ).
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The License field in the package spec file matches the actual license (Eclipse Public License v.1.0 as stated in the sources).
0 The file, containing the text of the license(s) for the package, does not included in %doc since upstream doesn't provide one.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided in the spec URL.

sulaco ~/rpmbuild/SOURCES: sha256sum technomancy-robert-hooke-1.1.2-18-g30d2f8f.tar.gz*
e6aa340d2a984122bc5cb6997af9cf0969381b429a313ec3ffb7b0c7c447280c  technomancy-robert-hooke-1.1.2-18-g30d2f8f.tar.gz
e6aa340d2a984122bc5cb6997af9cf0969381b429a313ec3ffb7b0c7c447280c  technomancy-robert-hooke-1.1.2-18-g30d2f8f.tar.gz.1
sulaco ~/rpmbuild/SOURCES: 

+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
0 No Javadoc stuff.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other packages.
+ All filenames in rpm packages are valid UTF-8.

I don't see any issues so this package is


Comment 5 Michel Alexandre Salim 2012-06-19 14:45:08 UTC
New Package SCM Request
Package Name: robert-hooke
Short Description: Extension mechanism for Clojure functions
Owners: salimma
Branches: f16 f17

Comment 6 Gwyn Ciesla 2012-06-19 15:15:56 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2012-06-20 17:04:22 UTC
robert-hooke-1.2.0-2.fc16 has been submitted as an update for Fedora 16.

Comment 8 Fedora Update System 2012-06-20 17:04:33 UTC
robert-hooke-1.2.0-2.fc17 has been submitted as an update for Fedora 17.

Comment 9 Fedora Update System 2012-06-22 08:35:57 UTC
robert-hooke-1.2.0-2.fc17 has been pushed to the Fedora 17 testing repository.

Comment 10 Fedora Update System 2012-06-30 22:04:12 UTC
robert-hooke-1.2.0-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 11 Fedora Update System 2012-06-30 22:11:01 UTC
robert-hooke-1.2.0-2.fc17 has been pushed to the Fedora 17 stable repository.

Note You need to log in before you can comment on or make changes to this bug.