Bug 831347 - firefox session manager support missing
firefox session manager support missing
Product: Fedora
Classification: Fedora
Component: firefox (Show other bugs)
x86_64 Linux
unspecified Severity unspecified
: ---
: ---
Assigned To: Søren Sandmann Pedersen
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2012-06-12 16:16 EDT by Oliver Henshaw
Modified: 2014-06-18 05:15 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-08-01 06:40:15 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
F14 .kde/share/config/ksmserverrc showing firefox in Sessions saved and no entries in LegacySession (2.08 KB, text/plain)
2012-06-12 16:20 EDT, Oliver Henshaw
no flags Details
F14 'grep ksm .xsession-errors' showing shutdown process with no legacy session apps (9.46 KB, text/plain)
2012-06-12 16:21 EDT, Oliver Henshaw
no flags Details
F16 .kde/share/config/ksmserverrc showing firefox in LegacySession (1.95 KB, text/plain)
2012-06-12 16:23 EDT, Oliver Henshaw
no flags Details
F16 'grep ksm .xsession-errors' showing shutdown process with one legacy session app and firefox missing from the list of normal programs (4.42 KB, text/plain)
2012-06-12 16:24 EDT, Oliver Henshaw
no flags Details

External Trackers
Tracker ID Priority Status Summary Last Updated
Mozilla Foundation 694570 None None None 2012-06-25 14:46:09 EDT

  None (edit)
Description Oliver Henshaw 2012-06-12 16:16:24 EDT
Description of problem:

KDE's ksmserver treats firefox as a 'legacy' app when saving the session during shutdown; this makes firefox's own session saving more likely to fail. This worked properly in Fedora 14, but not in F15+. It doesn't look like it's a firefox regression or a kde regression so I'm fingering libSM for now.

Firefox on a kde desktop on a low-powered amd brazos machine constantly loads up with the "Oops, this is embarassing" message when launched from the ksm session restore (on login). Some investigation (of ksmserverrc and .xsession-errors, see attached files) reveals that this is because ksmserver treats it as a 'legacy' app, whatever that means, and it look like legacy apps only get 4 seconds to shut themselves down before being killed, rather than the (I think) 10 seconds apps normally get.

I'm pretty sure firefox didn't use to be a legacy app and checking with old livecds reveales that I'm right - ksmserver in Fedora 14 treats firefox just like any other app, but this changes in F15 and persists through to F17.

See http://lxr.kde.org/source/kde/kde-workspace/ksmserver/ for what ksmserver is doing - the relevant files are shutdown.cpp and legacy.cpp

I thought that this could be due to F14 staying with firefox 3.6, but I tried with the up-to-date remi version (http://blog.famillecollet.com/) and:

F14-Fx3.6     NORMAL
F14-remiFx12  NORMAL
F15-Fx4       LEGACY
F15-Fx12      LEGACY
F15-remiFx12  LEGACY
F16-Fx13      LEGACY
F17-Fx13      LEGACY

(F15-remiFx12 is with remi's srpm rebuilt for F15). So it's not something introduced in newer firefox versions and it's not a difference between the fedora and remi builds of firefox. The Fedora 14 results remain unchanged when installing and fully updating the system. The Fedora 15 livecd has similar kde packages to a fully updated Fedora 14 system, so the problem may lie elsewhere.

Last known good packages:

First known bad packages:

Current packages:

Based on these package versions, I suspect that the regression is in libSM.
Comment 1 Oliver Henshaw 2012-06-12 16:20:11 EDT
Created attachment 591276 [details]
F14 .kde/share/config/ksmserverrc showing firefox in Sessions saved and no entries in LegacySession
Comment 2 Oliver Henshaw 2012-06-12 16:21:44 EDT
Created attachment 591282 [details]
F14 'grep ksm .xsession-errors' showing shutdown process with no legacy session apps
Comment 3 Oliver Henshaw 2012-06-12 16:23:11 EDT
Created attachment 591283 [details]
F16 .kde/share/config/ksmserverrc showing firefox in LegacySession
Comment 4 Oliver Henshaw 2012-06-12 16:24:46 EDT
Created attachment 591285 [details]
F16 'grep ksm .xsession-errors' showing shutdown process with one legacy session app and firefox missing from the list of normal programs
Comment 5 Oliver Henshaw 2012-06-12 16:33:19 EDT
Forgot to state clearly how to reproduce this:

This can be easily reproduced by booting the KDE live image in a VM, installing firefox, launching it and then logging out. And then examining ~/.kde/share/config/ksmserverrc.

You can also see the ksmserver output in ~/.xsession-errors after launching 'kdebugdialog' from the command-line, unticking 'Disable all debug output', (and optionally clicking 'Deselect All') and searching for 'ksm' to find the entries to select to see debug messages from ksmsever on the next login.
Comment 6 Oliver Henshaw 2012-06-13 11:16:21 EDT
I installed libSM-1.2.0-2.fc15 from the F14 live image but couldn't then trigger the 'legacy app' issue. So perhaps the regression isn't in libSM after all.

Any ideas?
Comment 7 Oliver Henshaw 2012-06-25 14:44:46 EDT
So this is apparently because firefox still relies on libgnome(ui) for its session-saving support - see https://bugzilla.mozilla.org/show_bug.cgi?id=694570 - but does not Require it.

Session-saving worked on the F14 KDE image because libgnome was installed, in F15 onwards it's gone. I'm not sure when things changed on the default/gnome live image, but firefox session-saving is broken in the same way on the F17 gnome spin.
I confirmed that this is the cause of the issue by removing libgnome from a F14 install (and seeing session-saving break) and by adding libgnomeui to a F15 install (and seeing session-saving fixed).

Note: A better way to test this issue is to use xprop to get WM_CLIENT_LEADER and then use it with 'xprop -id ID | grep SM_CLIENT_ID' to check whether firefox has session-saving support.
Comment 8 Dave Vasilevsky 2012-07-04 03:50:59 EDT
Thanks for the workaround Oliver! It's a relief to not have Firefox give me the "Oops, that was embarrassing" dialog every time I start it up after logging out.
Comment 9 Fedora End Of Life 2013-07-03 23:17:14 EDT
This message is a reminder that Fedora 17 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 17. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '17'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 17's end of life.

Bug Reporter:  Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 17 is end of life. If you 
would still like  to see this bug fixed and are able to reproduce it 
against a later version  of Fedora, you are encouraged  change the 
'version' to a later Fedora version prior to Fedora 17's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 10 Fedora End Of Life 2013-08-01 06:40:20 EDT
Fedora 17 changed to end-of-life (EOL) status on 2013-07-30. Fedora 17 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.