Bug 831871 - Review Request: openstack-swift-plugin-swift3 - The swift3 plugin for Openstack Swift
Summary: Review Request: openstack-swift-plugin-swift3 - The swift3 plugin for Opensta...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Alan Pevec
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-14 00:58 UTC by Pete Zaitcev
Modified: 2012-11-19 18:28 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-18 19:15:34 UTC
apevec: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Pete Zaitcev 2012-06-14 00:58:23 UTC
Spec URL: http://people.redhat.com/zaitcev/tmp/openstack-swift-plugin-swift3.spec-1.0.0-20120612.1
SRPM URL: http://people.redhat.com/zaitcev/tmp/openstack-swift-plugin-swift3-1.0.0-20120612.1.fc16.src.rpm
Description:
The swift3 plugin permits accessing Openstack Swift via the
Amazon S3 API.

Fedora Account System Username: zaitcev

Comment 1 Alan Pevec 2012-06-14 10:52:09 UTC
> # Completely bogus group, but Alan Pevec's openstack-swift uses it.
> Group:		Development/Languages

Credit where the credit is due :) This is in openstack-swift since initial import
http://pkgs.fedoraproject.org/gitweb/?p=openstack-swift.git;a=blob;f=openstack-swift.spec;h=a058d294da703b9cfca5f66259c0635209ab3096;hb=f3dc2f6e4d7546319ec80035139a324e7f3fd78f

I'll change it in openstack-swift to Applications/System (like in rest openstack-* apps) but not sure what group is the best fit for plugins like this.

E.g. OpenStack python-*client RPMs also have Group: Development/Languages
but looking at /usr/share/doc/rpm-*/GROUPS better might be Development/Libraries
or just completely drop Group: tag from spec?

Comment 2 Pete Zaitcev 2012-06-14 19:45:29 UTC
I was told by someone that we aim for a drop, distro-wide, but I do not
see it in guidelines.

Comment 3 Alan Pevec 2012-06-14 19:56:03 UTC
Yeah, then let's drop it, guidelines only mention that -doc subpackages should have Group: Documentation

My other remarks from the review:
- Source0: should be only filename when it's SCM snapshot
  http://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control
- Since it's a pre-release, Release: should be 0.1.%{snapshot_tag}
  http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
- In %files:
  %{python_sitelib}/*.egg-info would be easier for later updates

Rest of it is ok:
MUST
OK rpmlint
=> rpmlint openstack-swift-plugin-swift3-1.0.0-20120612.1.fc16.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK name
OK spec
   file name = %{name}.spec
   American English
   legible
   locales %find_lang
   UTF-8 filenames
[-] Packaging Guidelines
    Needs small adjusments per above remarks.

OK license
   Fedora approved
   spec field
   in %doc
OK sources
   url
=> git archive --format=tar --prefix=swift3-1.0.0-5c74ba04/ 5c74ba04 | xz - > ../swift3-1.0.0-5c74ba04.tar.xz
   md5sum
=> echo "b21822c4fbfaa40f4164b371764abf76  swift3-1.0.0-5c74ba04.tar.xz" | md5sum -c
swift3-1.0.0-5c74ba04.tar.xz: OK

OK BuildRequires
OK directories
   own all or require a package
   no directory conflicts
OK no dups in %files (exception: license texts)
OK Permissions
OK consistently use macros
OK code or permissable content

SHOULD
OK build in mock
=> http://koji.fedoraproject.org/koji/taskinfo?taskID=4161481

Comment 5 Alan Pevec 2012-06-14 21:01:41 UTC
approved

Comment 6 Pete Zaitcev 2012-06-14 22:13:05 UTC
New Package SCM Request
=======================
Package Name: openstack-swift-plugin-swift3
Short Description: The swift3 plugin for Openstack Swift
Owners: zaitcev
Branches: f17 f18
InitialCC: apevec

Comment 7 Gwyn Ciesla 2012-06-15 13:09:18 UTC
Git done (by process-git-requests).

No need to request f18, currently==devel.

Comment 8 Alan Pevec 2012-10-04 14:48:51 UTC
Package Change Request
======================
Package Name: openstack-swift-plugin-swift3
New Branches: el6
Owners: apevec zaitcev

Comment 9 Gwyn Ciesla 2012-10-04 14:58:20 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2012-10-05 09:57:27 UTC
openstack-swift-plugin-swift3-1.0.0-0.20120711git.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/openstack-swift-plugin-swift3-1.0.0-0.20120711git.el6

Comment 11 Fedora Update System 2012-11-19 18:28:19 UTC
openstack-swift-plugin-swift3-1.0.0-0.20120711git.el6, openstack-swift-1.7.4-2.el6, python-swiftclient-1.2.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.