Red Hat Bugzilla – Bug 832178
Review Request: python-django-picklefield - Implementation of a pickled object field
Last modified: 2012-06-29 03:33:26 EDT
Spec URL: http://www.matthias-runge.de/fedora/python-django-picklefield.spec
SRPM URL: http://www.matthias-runge.de/fedora/python-django-picklefield-0.2.1-1.fc17.src.rpm
Description: django-picklefield provides an implementation of a pickled object field.
Such fields can contain any picklable objects.
The implementation is taken and adopted from Django snippet #1694 by
Taavi Taijala, which is in turn based on Django snippet #513 by
Fedora Account System Username: mrunge
This is a review required for package rename.
[mrunge@sofja SPECS]$ rpmlint ./python-django-picklefield.spec ../SRPMS/python-django-picklefield-0.2.1-1.fc17.src.rpm ../RPMS/noarch/python-django-picklefield-0.2.1-1.fc17.noarch.rpm
python-django-picklefield.src: W: spelling-error %description -l en_US picklable -> pickle
python-django-picklefield.noarch: W: spelling-error %description -l en_US picklable -> pickle
python-django-picklefield.noarch: E: zero-length /usr/lib/python2.7/site-packages/picklefield/models.py
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
That zero-length file won't harm in any way.
I'll take this one for a review.
The only thing I would advise here is adding runtime dependency on Django (Requires: python-django), as the package needs Django to do something.
Otherwise I see no problems => The package is APPROVED.
thank you for the review!
I'll fix the requirement before submitting to scm.
New Package SCM Request
Package Name: python-django-picklefield
Short Description: Implementation of a pickled object field
Git done (by process-git-requests).
imported and built. Thanks
forgot to add: https://fedorahosted.org/rel-eng/ticket/5231