Spec URL: https://raw.github.com/Ignotus/kfaenza-icon-theme/9b73edcb414de0acc42a63479fcfaebb1ba749f6/kfaenza-icon-theme.spec SRPM URL: https://dl.dropbox.com/s/jvcfa97ow9xhl5g/kfaenza-icon-theme-0.8.9-1.fc17.src.rpm?dl=1 Description: Contains icons for Faenza-Cupertino theme for KDE Fedora Account System Username: ignotusp
*** Bug 832669 has been marked as a duplicate of this bug. ***
pre-review comments: 1. missing icon-related scriptlets, https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache Didn't look to check yet, but this theme may benefit from including Inherits=faenza in it's theme file. from faenza-icon-theme already in fedora.
SRPM: https://www.dropbox.com/s/35ymr1akaxwlih6/kfaenza-icon-theme-0.8.9-2.fc17.src.rpm SPEC: https://dl-web.dropbox.com/get/rpm/kfaenza-icon-theme.spec?w=26907e7f
Hi, can you please address the invalid-url and hidden-file-or-dir warnings? f17laptop:~ $ rpmlint ~/Downloads/kfaenza-icon-theme-0.8.9-2.fc17.src.rpm kfaenza-icon-theme.src: W: spelling-error Summary(en_US) Faenza -> Cadenza kfaenza-icon-theme.src: W: no-%build-section kfaenza-icon-theme.src: W: invalid-url Source0: http://ompldr.org/vYjR0NQ/kfaenza-icon-theme-0.8.9.tar.gz <urlopen error [Errno 111] Connection refused> 1 packages and 0 specfiles checked; 0 errors, 3 warnings. f17laptop:~ $ rpmlint /home/bsjones/rpmbuild/RPMS/noarch/kfaenza-icon-theme-0.8.9-2.fc17.noarch.rpm kfaenza-icon-theme.noarch: W: spelling-error Summary(en_US) Faenza -> Cadenza kfaenza-icon-theme.noarch: W: no-documentation kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/32/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/emblems/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/32/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/emblems/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/32/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/mimetypes/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/128/.directory kfaenza-icon-theme.noarch: E: zero-length /usr/share/icons/KFaenza/actions/64/stock_new-address-book.png kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/mimetypes/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/mimetypes/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/emblems/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/mimetypes/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/emblems/32/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/emblems/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/mimetypes/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/.directory
Have you tried to download this link (http://omploader.org/vYjR0NQ/kfaenza-icon-theme-0.8.9.tar.gz ) by wget? It works.
Hidden files have been removed: SPEC: https://raw.github.com/Ignotus/fedora-packages/cc195da803c2dd195727dc2ebb4399503e81677b/kfaenza-icon-theme/kfaenza-icon-theme.spec SRPM file is too large for uploading. Please use BUILD.sh script from https://github.com/Ignotus/fedora-packages/tree/cc195da803c2dd195727dc2ebb4399503e81677b/kfaenza-icon-theme for building. Patches are there too.
$ rpmlint kfaenza-icon-theme.spec kfaenza-icon-theme.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings. naming: ok 1. SHOULD drop index.patch, I don't think it's helpful. Looks like faenza actually installs as Faenza ondisk, and the other inherits look legit to me. 2. MUST drop -f from gtk-update-icon-cache scriptlet calls (the guidelines were recently fixed to not include that) 3. SHOULD drop deprecated/unused .spec tags, including: Group: 4. SHOULD drop BuildRequires: gtk2 >= 2.6.0 doesn't look like it's used or needed here (if it is, please document why in the .spec) 5. SHOULD ping upstream to include licensing information/file in their source tarball 6. SHOULD consider using the included INSTALL script in some form. it looks like it creates a bunch of compatibiliy symlinks for various things
ping, it's been a little while, you still able and interested in kfaenza-icon-theme ?
Yes.
On the other hand, pretty much all of my comments are non-blockers (even the scriptlet thing, it's only an optimization). APPROVED i'll try to look things over again once you've imported it to be sure, and please do address all those SHOULD items prior to doing any official builds. thanks.
New Package SCM Request ======================= Package Name: kfaenza-icon-theme Short Description: Faenza-Cupertino Icon Theme for KDE Owners: minh Branches: f16 f17 f18 InitialCC:
Git done (by process-git-requests).
kfaenza-icon-theme-0.8.9-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kfaenza-icon-theme-0.8.9-3.fc16
kfaenza-icon-theme-0.8.9-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kfaenza-icon-theme-0.8.9-3.fc17
kfaenza-icon-theme-0.8.9-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kfaenza-icon-theme-0.8.9-3.fc18
kfaenza-icon-theme-0.8.9-3.fc18 has been pushed to the Fedora 18 testing repository.
kfaenza-icon-theme-0.8.9-3.fc16 has been pushed to the Fedora 16 stable repository.
kfaenza-icon-theme-0.8.9-3.fc17 has been pushed to the Fedora 17 stable repository.
kfaenza-icon-theme-0.8.9-3.fc18 has been pushed to the Fedora 18 stable repository.