Spec URL: http://beckerde.fedorapeople.org/transifex/python-django-addons.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/python-django-addons-0.6.4-6.fc18.src.rpm Description: A Django app used to add true plug-n-play functionality to your own Django applications and projects. Fedora Account System Username: beckerde
I'll take this one.
- I think that BR: python-setuptools-devel should be python-setuptools, shouldn't it? - rpmlint is reporting filesize mismatch. Could you redownload the package and create new SRPM? python-django-addons.src: W: file-size-mismatch django-addons-0.6.4.tar.gz = 15567, http://pypi.python.org/packages/source/d/django-addons/django-addons-0.6.4.tar.gz = 15958 - There are some things that are only needed for EPEL 5, do you plan to build your package there, too? Otherwise you can remove them: BuildRoot tag, %clean section, rm -rf $RPM_BUILD_ROOT, %defattr(-,root,root,-) Otherwise the package looks good, so once you fix these issues, please post the updated SPEC/SRPM here so I can have a final look and approve the package.
(In reply to comment #2) > - I think that BR: python-setuptools-devel should be python-setuptools, > shouldn't it? > - rpmlint is reporting filesize mismatch. Could you redownload the package > and create new SRPM? > > python-django-addons.src: W: file-size-mismatch django-addons-0.6.4.tar.gz = > 15567, > http://pypi.python.org/packages/source/d/django-addons/django-addons-0.6.4. > tar.gz = 15958 > Fixed. > - There are some things that are only needed for EPEL 5, do you plan to > build your package there, too? Otherwise you can remove them: BuildRoot tag, > %clean section, rm -rf $RPM_BUILD_ROOT, %defattr(-,root,root,-) > Fixed. New spec and srpm: Spec URL: http://beckerde.fedorapeople.org/transifex/python-django-addons.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/python-django-addons-0.6.4-7.fc18.src.rpm
There is one more line that can be removed: "BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)". Please remove it before commiting to dist-git. Otherwise everything looks good, this package is APPROVED.
New Package SCM Request ======================= Package Name: python-django-addons Short Description: A framework to create pluggable Django add-ons Owners: beckerde Branches: InitialCC: diegobz
Git done (by process-git-requests).
(In reply to comment #4) > There is one more line that can be removed: "BuildRoot: > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)". Please > remove it before commiting to dist-git. > > Otherwise everything looks good, this package is APPROVED. Done. Many thanks.