Red Hat Bugzilla – Bug 832810
Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter
Last modified: 2012-07-07 17:55:49 EDT
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Method-Signatures.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Method-Signatures-20120523-1.fc18.src.rpm
Provides two new keywords, func and method, so that you can write
subroutines with signatures.
Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=4172212
The fedora-review reports are getting insanely long; I guess I'll just stop pasting them :)
Anyhow, after going through your package...
TODO: Missing BRs: perl(base), perl(Exporter), perl(Role::Basic), and possibly even perl(MooseX::Declare::Syntax::Keyword::Method) and perl(MooseX::Declare::Syntax::Keyword::MethodModifier) to be on the safe side.
TODO: Remove underspecified runtime deps, perl(Data::Alias), perl(Devel::Pragma), and perl(Sub::Name)
No blockers, approving.
New Package SCM Request
Package Name: perl-Method-Signatures
Short Description: Method and function declarations with signatures and no source filter
Branches: f16 f17
Git done (by process-git-requests).
perl-Method-Signatures-20120523-2.fc17 has been submitted as an update for Fedora 17.
perl-Method-Signatures-20120523-2.fc16 has been submitted as an update for Fedora 16.
Thanks for the review, Petr. I've added the additional BRs, except Role::Basic which we don't (yet) have. Upstream notes in the test, though, that Role::Basic support isn't really a viable use case.
perl-Method-Signatures-20120523-2.fc16 has been pushed to the Fedora 16 testing repository.
perl-Method-Signatures-20120523-2.fc16 has been pushed to the Fedora 16 stable repository.
perl-Method-Signatures-20120523-2.fc17 has been pushed to the Fedora 17 stable repository.