Bug 832810 - Review Request: perl-Method-Signatures - Method and function declarations with signatures and no source filter
Summary: Review Request: perl-Method-Signatures - Method and function declarations wit...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-17 14:34 UTC by Iain Arnell
Modified: 2012-07-07 21:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-07 21:53:52 UTC
Type: ---
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Iain Arnell 2012-06-17 14:34:02 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Method-Signatures.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Method-Signatures-20120523-1.fc18.src.rpm
Description: 
Provides two new keywords, func and method, so that you can write
subroutines with signatures.

Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=4172212

Comment 1 Petr Šabata 2012-06-26 10:53:39 UTC
The fedora-review reports are getting insanely long; I guess I'll just stop pasting them :)

Anyhow, after going through your package...

TODO: Missing BRs: perl(base), perl(Exporter), perl(Role::Basic), and possibly even perl(MooseX::Declare::Syntax::Keyword::Method) and perl(MooseX::Declare::Syntax::Keyword::MethodModifier) to be on the safe side.
TODO: Remove underspecified runtime deps, perl(Data::Alias), perl(Devel::Pragma), and perl(Sub::Name)

No blockers, approving.

Comment 2 Iain Arnell 2012-06-27 11:20:58 UTC
New Package SCM Request
=======================
Package Name: perl-Method-Signatures
Short Description: Method and function declarations with signatures and no source filter
Owners: iarnell
Branches: f16 f17
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2012-06-27 12:46:17 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2012-06-28 12:07:41 UTC
perl-Method-Signatures-20120523-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-Method-Signatures-20120523-2.fc17

Comment 5 Fedora Update System 2012-06-28 12:07:50 UTC
perl-Method-Signatures-20120523-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-Method-Signatures-20120523-2.fc16

Comment 6 Iain Arnell 2012-06-28 12:14:10 UTC
Thanks for the review, Petr. I've added the additional BRs, except Role::Basic which we don't (yet) have. Upstream notes in the test, though, that Role::Basic support isn't really a viable use case.

Comment 7 Fedora Update System 2012-06-30 08:24:06 UTC
perl-Method-Signatures-20120523-2.fc16 has been pushed to the Fedora 16 testing repository.

Comment 8 Fedora Update System 2012-07-07 21:53:52 UTC
perl-Method-Signatures-20120523-2.fc16 has been pushed to the Fedora 16 stable repository.

Comment 9 Fedora Update System 2012-07-07 21:55:49 UTC
perl-Method-Signatures-20120523-2.fc17 has been pushed to the Fedora 17 stable repository.


Note You need to log in before you can comment on or make changes to this bug.