Red Hat Bugzilla – Bug 8330
tar 1.13.16 doesn't always ignore failed read during incremental archive build
Last modified: 2008-05-01 11:37:53 EDT
Tar 1.13.16 doesn't always ignore a failed read when it encounters one while building an incremental archive, when --ignore-failed-read is set. Here's a patch (not fully tested, but it's pretty straightforward): --- src/incremen.c.orig Mon Jan 10 08:40:42 2000 +++ src/incremen.c Mon Jan 10 08:41:54 2000 @@ -228,7 +228,10 @@ if (deref_stat (dereference_option, name_buffer, &stat_data)) { - stat_error (name_buffer); + if (ignore_failed_read_option && (errno == ENOENT)) + stat_warn (name_buffer); + else + stat_error (name_buffer); continue; }
Should be fixed in 1.3.17.
I found another place where failed reads are not ignored and should be. Here's an updated patch which covers both cases. --- tar-1.13.16/src/incremen.c Fri Dec 10 14:41:30 1999 +++ tar-1.13.16.new/src/incremen.c Thu Jan 13 09:12:40 2000 @@ -228,7 +228,10 @@ if (deref_stat (dereference_option, name_buffer, &stat_data)) { - stat_error (name_buffer); + if (ignore_failed_read_option && (errno == ENOENT)) + stat_warn (name_buffer); + else + stat_error (name_buffer); continue; } --- tar-1.13.16/src/names.c Wed Dec 8 18:14:28 1999 +++ tar-1.13.16.new/src/names.c Thu Jan 13 09:28:09 2000 @@ -822,7 +822,10 @@ if (deref_stat (dereference_option, name->name, &statbuf) != 0) { - stat_error (name->name); + if (ignore_failed_read_option && (errno == ENOENT)) + stat_warn (name->name); + else + stat_error (name->name); continue; } if (S_ISDIR (statbuf.st_mode))
Neither the fix to incremen.c nor the fix to names.c appears in 1.13.17.
Thanks, fixed in 1.3.17-10