Spec URL: http://fedorapeople.org/~grover/new/rawdog.spec SRPM URL: http://fedorapeople.org/~grover/new/rawdog-2.13-1.fc17.src.rpm Description: Rawdog aggregates RSS feeds to generate an HTML page, commonly published as "planets" on the internet. An example (my personal planet) is http://planet.groveronline.com/ . Fedora Account System Username: grover Note on packaging: Rawdog includes feedparser (http://code.google.com/p/feedparser/) which is packaged in python-feedparser, unfortunately Rawdog uses a significantly modified version so I thought it best not to try to make it work with the upstream version.
Updated to latest version. Spec URL: http://fedorapeople.org/~grover/new/rawdog.spec SRPM URL: http://fedorapeople.org/~grover/new/rawdog-2.15-1.fc19.src.rpm No longer bundles feedparser, so add python-feedparser as a Requires.
Well actually 2.15 still bundles feedparser, but upstream may release a 2.16 that has it removed.
Yep, brand new 2.16 removes private feedparser.py. Updated: Spec URL: http://fedorapeople.org/~grover/new/rawdog.spec SRPM URL: http://fedorapeople.org/~grover/new/rawdog-2.16-1.fc19.src.rpm
I'll take this.
Package is fine. I'm going to give you fedora-review BUT there are some weird things: ISC --- /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/rawdog-2.16/rawdoglib/feedscanner.py Unknown or generated -------------------- /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/rawdog-2.16/rawdoglib/__init__.py /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/rawdog-2.16/rawdoglib/persister.py /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/rawdog-2.16/rawdoglib/plugins.py /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/rawdog-2.16/rawdoglib/rawdog.py /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/rawdog-2.16/setup.py /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/rawdog-2.16/testserver.py First, can you tell me why ISC is presented? Then, can you suggest upstream that adding license header for those files?
I don't know why ISC is showing up. feedscanner.py has a license header, it appears to have a looser license than other files. (But since the other files are GPLv2+ then the overall package is GPLv2+.) I looked at all those "unknown" files and they all have "GPLv2 or later" headers, so it seems like fedora-review's license detection is wonky.
OK. APPROVED.
Thanks for the review! :)
New Package SCM Request ======================= Package Name: rawdog Short Description: RSS Aggregator Without Delusions of Grandeur Owners: grover Branches: f18 f19 el5 el6 InitialCC:
Git done (by process-git-requests).