RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 833381 - 3.1 - [Storage] Disconnect storage pool thorough an exception.
Summary: 3.1 - [Storage] Disconnect storage pool thorough an exception.
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: vdsm
Version: 6.3
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: rc
: ---
Assignee: Eduardo Warszawski
QA Contact: Haim
URL:
Whiteboard: Storage
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-19 11:11 UTC by Leonid Natapov
Modified: 2014-07-01 11:59 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-12 08:29:20 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
vdsm log (948.39 KB, application/octet-stream)
2012-06-19 11:11 UTC, Leonid Natapov 		no flags Details
View All

Description Leonid Natapov 2012-06-19 11:11:19 UTC 
Created attachment 592915 [details]
vdsm log

[Storage] Disconnect storage pool thorough an exception.
I was trying to switch to maintenance Master SD. Here is the exception.
When I tried to activate Master I got another exception saying that version or spm id is invalid. It described in BZ833084. This bug and the current bug might be related. VDSM log attached.

Thread-4128::DEBUG::2012-06-19 12:37:39,654::BindingXMLRPC::156::vds::(wrapper) [10.35.97.32]
Thread-4128::DEBUG::2012-06-19 12:37:39,654::task::588::TaskManager.Task::(_updateState) Task=`fe864837-2276-4a68-9d47-abbd3a88136d`::moving from
state init -> state preparing
Thread-4128::INFO::2012-06-19 12:37:39,655::logUtils::37::dispatcher::(wrapper) Run and protect: disconnectStoragePool(spUUID='347bb22d-598b-44bc-
8b05-e1b176d30bef', hostID=1, scsiKey='347bb22d-598b-44bc-8b05-e1b176d30bef', remove=False, options=None)
Thread-4128::DEBUG::2012-06-19 12:37:39,655::resourceManager::175::ResourceManager.Request::(__init__) ResName=`Storage.347bb22d-598b-44bc-8b05-e1
b176d30bef`ReqID=`94da7613-f0f8-4a08-a690-74e0a2a830c1`::Request was made in '/usr/share/vdsm/storage/resourceManager.py' line '485' at 'registerR
esource'
Thread-4128::DEBUG::2012-06-19 12:37:39,655::resourceManager::486::ResourceManager::(registerResource) Trying to register resource 'Storage.347bb2
2d-598b-44bc-8b05-e1b176d30bef' for lock type 'exclusive'
Thread-4128::DEBUG::2012-06-19 12:37:39,655::resourceManager::528::ResourceManager::(registerResource) Resource 'Storage.347bb22d-598b-44bc-8b05-e
1b176d30bef' is free. Now locking as 'exclusive' (1 active user)
Thread-4128::DEBUG::2012-06-19 12:37:39,656::resourceManager::212::ResourceManager.Request::(grant) ResName=`Storage.347bb22d-598b-44bc-8b05-e1b17
6d30bef`ReqID=`94da7613-f0f8-4a08-a690-74e0a2a830c1`::Granted request
Thread-4128::DEBUG::2012-06-19 12:37:39,656::task::817::TaskManager.Task::(resourceAcquired) Task=`fe864837-2276-4a68-9d47-abbd3a88136d`::_resourc
esAcquired: Storage.347bb22d-598b-44bc-8b05-e1b176d30bef (exclusive)
Thread-4128::DEBUG::2012-06-19 12:37:39,656::task::978::TaskManager.Task::(_decref) Task=`fe864837-2276-4a68-9d47-abbd3a88136d`::ref 1 aborting Fa
lse
Thread-4128::INFO::2012-06-19 12:37:39,657::sp::659::Storage.StoragePool::(disconnect) Disconnect from the storage pool 347bb22d-598b-44bc-8b05-e1
b176d30bef
Thread-4128::ERROR::2012-06-19 12:37:39,657::task::853::TaskManager.Task::(_setError) Task=`fe864837-2276-4a68-9d47-abbd3a88136d`::Unexpected erro
r
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 861, in _run
    return fn(*args, **kargs)
  File "/usr/share/vdsm/logUtils.py", line 38, in wrapper
    res = f(*args, **kwargs)
  File "/usr/share/vdsm/storage/hsm.py", line 901, in disconnectStoragePool
    return self._disconnectPool(pool, hostID, scsiKey, remove)
  File "/usr/share/vdsm/storage/hsm.py", line 905, in _disconnectPool
Comment 3 Eduardo Warszawski 2012-07-12 08:29:20 UTC 
The complete trace is:

Thread-4128::ERROR::2012-06-19 12:37:39,657::task::853::TaskManager.Task::(_setError) Task=`fe864837-2276-4a68-9d47-abbd3a88136d`::Unexpected error
Traceback (most recent call last):
  File "/usr/share/vdsm/storage/task.py", line 861, in _run
    return fn(*args, **kargs)
  File "/usr/share/vdsm/logUtils.py", line 38, in wrapper
    res = f(*args, **kwargs)
  File "/usr/share/vdsm/storage/hsm.py", line 901, in disconnectStoragePool
    return self._disconnectPool(pool, hostID, scsiKey, remove)
  File "/usr/share/vdsm/storage/hsm.py", line 905, in _disconnectPool
    res = pool.disconnect()
  File "/usr/share/vdsm/storage/sp.py", line 677, in disconnect
    fileUtils.safeUnlink(self._poolFile)
AttributeError: 'module' object has no attribute 'safeUnlink'

The actual master code uses os.unlink() instead the inexistent fileUtils.safeUnlink().
The same is true for the 3.1 and 3.0 branches.
Our git history show no traces of fileUtils.safeUnlink() calls.
Seems that this bug was present only in a private build.
Please verify on an official build and reopen if reproduced.
Note You need to log in before you can comment on or make changes to this bug.