Bug 833787 - ovirt-engine-backend: we are able to add a disk during create snapshot
Summary: ovirt-engine-backend: we are able to add a disk during create snapshot
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.1.0
Hardware: x86_64
OS: Linux
urgent
high
Target Milestone: ---
: 3.1.0
Assignee: mkublin
QA Contact: Dafna Ron
URL:
Whiteboard: storage
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-20 11:16 UTC by Dafna Ron
Modified: 2016-02-10 17:14 UTC (History)
9 users (show)

Fixed In Version: SI8
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
log (27.01 KB, application/x-xz)
2012-06-20 11:16 UTC, Dafna Ron
no flags Details
log (2.48 KB, application/x-xz)
2012-06-25 14:22 UTC, Dafna Ron
no flags Details

Description Dafna Ron 2012-06-20 11:16:57 UTC
Created attachment 593180 [details]
log

Description of problem:

since snapshot is on entire vm and not just the disks, and we cancelled the image lock on vm during snapshot we should add a CanDoAction on add disk while disk images are locked due to snapshot to prevent possible races which will cause image corruption. 

Version-Release number of selected component (if applicable):

si6

How reproducible:

100%

Steps to Reproduce:
1. create a snapshot
2. create a new disk
3.
  
Actual results:

vm is not locked only disk images and there is no CanDoAction -> new disk will be created while a snapshot is taken. 

Expected results:

we should add CanDoAction to add disk if the disk images are locked due to snapshot. 

Additional info:backend log

Comment 1 mkublin 2012-06-20 11:31:13 UTC
http://gerrit.ovirt.org/#/c/5528/

Comment 2 Dafna Ron 2012-06-25 14:22:04 UTC
not solved 
I was still able to create the disk while snapshot was created. 
logs attached

Comment 3 Dafna Ron 2012-06-25 14:22:38 UTC
Created attachment 594196 [details]
log

Comment 4 mkublin 2012-06-26 06:51:29 UTC
I don't see any problm at logs, just clog for creating disk

Comment 5 mkublin 2012-06-27 07:28:45 UTC
recheck at si8, I suppose the fix was not there

Comment 6 Dafna Ron 2012-07-01 15:30:47 UTC
verified on si8


Note You need to log in before you can comment on or make changes to this bug.