Bug 834021 - ovirt-engine-backend: there is no validation on domain status when deleting snapshot
Summary: ovirt-engine-backend: there is no validation on domain status when deleting s...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.1.0
Hardware: x86_64
OS: Linux
high
medium
Target Milestone: ---
: 3.1.0
Assignee: mkublin
QA Contact: Dafna Ron
URL:
Whiteboard: storage
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-20 15:40 UTC by Dafna Ron
Modified: 2016-02-10 16:31 UTC (History)
12 users (show)

Fixed In Version: si7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-04 20:01:25 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
logs (645.22 KB, application/x-gzip)
2012-06-20 15:41 UTC, Dafna Ron
no flags Details

Description Dafna Ron 2012-06-20 15:40:02 UTC
Description of problem:

in multiple domains we have no validation on domain status in backend and command is sent to vdsm. 
this may cause races which will leave orphen objects on the domain. 
please add validation on domain status for snapshots in backend. 

Version-Release number of selected component (if applicable):

si6

How reproducible:

100%

Steps to Reproduce:
1. create 2 domains
2. create vm with 2 disks on each of the domains and create snapshot
3. put domain in maintenance (not the master domain)
4. delete snapshot
  
Actual results:

delete snapshot will be sent to vdsm

Expected results:

we should validate domain status before sending command

Additional info: logs

Comment 1 Dafna Ron 2012-06-20 15:41:02 UTC
Created attachment 593255 [details]
logs

Comment 2 mkublin 2012-06-21 08:48:41 UTC
Actually u failed on canDoaction, but ttese validation was with sending request to vdsm
I changed an order from now a request to vdsm will be send at end.

http://gerrit.ovirt.org/#/c/5571/

Pushed

Comment 3 Dafna Ron 2012-06-25 14:35:23 UTC
verified on si7


Note You need to log in before you can comment on or make changes to this bug.