Spec URL: http://bkabrda.fedorapeople.org/pkgs/sure/python-sure.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/sure/python-sure-0.10.3-1.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4186773 Description: A Python assertion toolbox that works fine with nose. Fedora Account System Username: bkabrda
some drive by comments: - homepage akkording to http://pypi.python.org/pypi/sure/0.10.3 is likely https://github.com/gabrielfalcao/sure - BuildRequires: python-devel should be BuildReqires: python2-devel - is there a python3 version? everything else looks pretty fine. Detailed review to come.
Thanks for the initial comments, here are the fixed spec and srpm (the homepage issue was a problem in pyp2rpm getting wrong data, I already fixed that upstream, thanks for pointing that out). http://bkabrda.fedorapeople.org/pkgs/sure/python-sure.spec http://bkabrda.fedorapeople.org/pkgs/sure/python-sure-0.10.3-2.fc17.src.rpm
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint python-sure-0.10.3-2.fc18.src.rpm python-sure.src: W: invalid-url Source2: sure-0.10.3-tests.tgz python-sure.src: W: file-size-mismatch COPYING = 1086, https://raw.github.com/gabrielfalcao/sure/master/COPYING = 1 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint python-sure-0.10.3-2.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/mrunge/review/834501/834501/sure-0.10.3.tar.gz : MD5SUM this package : 84cf25264a77177d052e241bdb9d7c77 MD5SUM upstream package : 84cf25264a77177d052e241bdb9d7c77 /home/mrunge/review/834501/834501/COPYING : MD5SUM this package : 0111a5e431be12938a76cd45fb17234f MD5SUM upstream package : 0111a5e431be12938a76cd45fb17234f [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [!]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Rpmlint output is silent. rpmlint python-sure-0.10.3-2.fc18.src.rpm python-sure.src: W: invalid-url Source2: sure-0.10.3-tests.tgz python-sure.src: W: file-size-mismatch COPYING = 1086, https://raw.github.com/gabrielfalcao/sure/master/COPYING = 1 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint python-sure-0.10.3-2.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint There seems to be a problem with that COPYING file (file size mismatch) If you could take a second look onto that before import? Package APPROVED
Thank you! The problem with COPYING is a problem with pointing to Github. It uses some redirections or something like that, so rpmlint doesn't actually get to the file. Anyway, the file should reach the next upstream release, so it will be ok then. New Package SCM Request ======================= Package Name: python-sure Short Description: Assertion toolbox for python Owners: bkabrda Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: python-sure New Branches: el6 Owners: bkabrda
Package Change Request ====================== Package Name: python-sure New Branches: epel7 Owners: bkabrda
Already exists.