Bug 834582 - Review Request: java-deptools - Java RPM dependency tools
Review Request: java-deptools - Java RPM dependency tools
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Gerard Ryan
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-22 09:54 EDT by Mikolaj Izdebski
Modified: 2012-06-27 08:37 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-06-27 08:37:55 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
gerard: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Mikolaj Izdebski 2012-06-22 09:54:38 EDT
Spec URL: http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.1.20120621git2a6a72d.spec
SRPM URL: http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.1.20120621git2a6a72d.fc16.src.rpm
Description: This package provides tools for tracking dependencies between Java packages in RPM-based distributions.
Fedora Account System Username: mizdebsk
Comment 1 Gerard Ryan 2012-06-22 10:29:07 EDT
I'm taking this.
Comment 2 Gerard Ryan 2012-06-22 12:16:35 EDT
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint java-deptools-0-0.1.20120621git2a6a72d.fc18.src.rpm

java-deptools.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint java-deptools-0-0.1.20120621git2a6a72d.fc18.noarch.rpm

java-deptools.noarch: I: enchant-dictionary-not-found en_US
java-deptools.noarch: W: incoherent-version-in-changelog 0-0.1.20120621git20120621 ['0-0.1.20120621git2a6a72d.fc18', '0-0.1.20120621git2a6a72d']
java-deptools.noarch: W: class-path-in-manifest /usr/share/java/java-deptools.jar
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint java-deptools-javadoc-0-0.1.20120621git2a6a72d.fc18.noarch.rpm

java-deptools-javadoc.noarch: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/packager/review/834582/ :
  MD5SUM this package     : None
  MD5SUM upstream package : None

[x]: MUST Spec file is legible and written in American English.
[!]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
     Note: java-deptools-0-0.1.20120621git2a6a72d.spec should be java-
     deptools.spec
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[!]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.


==== Java ====
[x]: MUST If source tarball includes bundled jar/class files these need to be
     removed prior to building
[x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: MUST Javadoc subpackages have Requires: jpackage-utils
[x]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version}
     symlink)
[x]: SHOULD Package has BuildArch: noarch (if possible)
[x]: SHOULD Package uses upstream build method (ant/maven/etc.)


==== Maven ====
[x]: MUST Pom files have correct add_maven_depmap call
     Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: MUST Old add_to_maven_depmap macro is not being used
[x]: MUST Packages DOES NOT have Requires(post) and Requires(postun) on
     jpackage-utils for %update_maven_depmap macro
[x]: MUST If package contains pom.xml files install it (including depmaps)
     even when building with ant
[x]: MUST Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: MUST Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms


Issues:

1. Changelog entry version is incorrect
java-deptools.noarch: W: incoherent-version-in-changelog 0-0.1.20120621git20120621 ['0-0.1.20120621git2a6a72d.fc18', '0-0.1.20120621git2a6a72d']

2. specfile name should be java-deptools.spec
[!]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.

3. Line 60 of specfile should have 'cp -pR' instead of 'cp -R'
[!]: SHOULD Packages should try to preserve timestamps of original installed
     files.
Comment 3 Mikolaj Izdebski 2012-06-22 12:52:21 EDT
(In reply to comment #2)
> 1. Changelog entry version is incorrect
> java-deptools.noarch: W: incoherent-version-in-changelog
> 0-0.1.20120621git20120621 ['0-0.1.20120621git2a6a72d.fc18',
> '0-0.1.20120621git2a6a72d']

Corrected:
Spec URL: http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.2.20120621git2a6a72d.spec
SRPM URL: http://mizdebsk.fedorapeople.org/review/java-deptools/java-deptools-0-0.2.20120621git2a6a72d.fc16.src.rpm

> 2. specfile name should be java-deptools.spec
> [!]: MUST Spec file name must match the spec package %{name}, in the format
>      %{name}.spec.

It really *IS* named %{name}.spec. You can extract the SRPM and you'll see it is named "java-deptools.spec". Only the name in the URL used only for this review is different.

> 3. Line 60 of specfile should have 'cp -pR' instead of 'cp -R'
> [!]: SHOULD Packages should try to preserve timestamps of original installed
>      files.

Guidelines says that "original files" should have their timestamps preserved, but files in "target/site/apidocs" are NOT original files -- they are being generated during build time. Their times are set during the build time and preserving them makes no sense. The only original file, pom.xml, does have its timestamp preserved.
Comment 4 Gerard Ryan 2012-06-22 14:55:11 EDT
(In reply to comment #3)
> It really *IS* named %{name}.spec. You can extract the SRPM and you'll see
> it is named "java-deptools.spec". Only the name in the URL used only for
> this review is different.
> 

Ah yes, my mistake (or the mistake of fedora-review tool, rather).

> 
> Guidelines says that "original files" should have their timestamps
> preserved, but files in "target/site/apidocs" are NOT original files -- they
> are being generated during build time. Their times are set during the build
> time and preserving them makes no sense. The only original file, pom.xml,
> does have its timestamp preserved.

Yes, you are right!

Everything else looks good, thanks for such a useful tool!

================
*** APPROVED ***
================
Comment 5 Mikolaj Izdebski 2012-06-22 16:16:25 EDT
Thank you!

New Package SCM Request
=======================
Package Name: java-deptools
Short Description: Java RPM dependency tools
Owners: mizdebsk
Branches: f17
Comment 6 Gwyn Ciesla 2012-06-22 21:55:37 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.