Description of problem: Some tasks related events are not translated properly , e.g when attaching tag to VM i see the following message under tasks: "AttachVmsToTag" ( why is it task BTW? ) Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
also when adding a disk: "Adding Disk DiskName"
"Failed to restart VM 33-4 on Host VdsName"
"Add-Disk operation of 'dd' was initiated on VM VmName by vdcadmin."
I took a look, and there are many tag/bookmark operations that are monitored (i.e. appear in the tasks tab). Should I remove them all? Don't seem to be very relevant to be monitored as tasks.
Need info regarding the messages as well (in addition to my previous comment on monitoring the task). 1. "Failed to restart VM 33-4 on Host VdsName" 2. "Add-Disk operation of 'dd' was initiated on VM VmName by vdcadmin." Message #1 can be caused due to the host being null in the code, and that might happen if it wasn't set at all. Can we remove the VdsName from this message? If not, we need to switch to two message, one when the host is null, and one when it isn't. A log can help here to see how you got to this situation. Message #2 - it is simple. We use the same code when adding a disk to a VM, and when adding it independently. In the former the log is correct, however in the latter no VM is involved, so the VM is null. Should we split it to two different messages, or using the message "Add-Disk operation of 'dd' was initiated by vdcadmin" enough?
Message 1: this is a corner case - it is suffiecent to change the VdsName to <null>. Message 2: Split is required. The VmName is important for the Advance View of the Events TAB. It is used for auditing mechanism.
Commits: f5876e63162fbfac90e7b825c76bcaa80dfcef2a f3853877f9cf4f371712868c822393b8f2c67ad6 38d529716c47bc5e99ffd26f2f8607330a0d652c http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=f5876e63162fbfac90e7b825c76bcaa80dfcef2a http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=f3853877f9cf4f371712868c822393b8f2c67ad6 http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=38d529716c47bc5e99ffd26f2f8607330a0d652c
Verified - si12 - All message types mentioned above are properly translated.