Red Hat Bugzilla – Bug 835318
bbdb fails to add new e-mail addresses because emacs-24 changes run-hook-with-args return value
Last modified: 2012-07-19 05:18:49 EDT
Description of problem:
(defun bbdb-canonicalize-address (net)
but as of 24.0.50 that no longer returns a value:
as a result, bbdb no longer records new e-mail addresses :-(
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.Run emacs and browse a new message (a message that bbdb has never seen)
in your mail reader that uses bbdb.
(For me, mh-e.)
2. Execute something that should discover the e-mail address in the current message,
like M-x bbdb/mh-pop-up-bbdb-buffer
3. be sad when the buffer shows a name, but no bbdb-snarf'ed e-mail address
new bbdb record created with a name, but no net: field
a new bbdb record with both a name and an e-mail address grabbed from the message
discusses the problem and identifies emacs-24's helpfully documented change in the run-hook-with-args command
I have a fix that I will post in a followup.
Created attachment 594317 [details]
patch to fix run-hook-with-args API change in emacs-24 triggered by bbdb
Thanks for your report. I'll try to take care of this; I am a new co-maintainer of the emacs-bbdb package.
Since you have investigated the issue, have you also checked if the upstreams are aware already? Or should we point it out them (him)?
I attempted to post the bug to the bbdb-info mailing list, but my post was held for moderator approval (even after I joined the list). If you know a better way to upstream the bug, please advise.
I have no special contacts with upstreams, but I did manage to send a message to the bbdb-info mailing list after subscribing. I don't know why it worked for me but not for you, but there is a short report there now.
Your patch didn't quite apply, so I had to adjust it somewhat. I hope I got it right, but please do test the update I'll push shortly. I don't normally use bbdb, so the testing I can do myself is a bit rudimentary, to put it mildly.
emacs-bbdb-2.35-8.fc17 has been submitted as an update for Fedora 17.
Thanks, can you post the updated patch (mentioned in comment #4) so I can try it in parallel with the new package coming down the line?
I guess the best testing is if you pick up the packages directly via https://admin.fedoraproject.org/updates/emacs-bbdb-2.35-8.fc17
Yes, I went there. It's Much Less Than Obvious which of the several links gets me to the patch, or even the source or binary of the package itself. (I think I've now found the src.rpm, but whew...a maze of twistly URLs, all alike.)
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing emacs-bbdb-2.35-8.fc17'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
> It's Much Less Than Obvious which of the several links gets me to the patch
Um, right. I could have put in more direct URL:s I guess. I'll try to think about that next time. (This package is available in testing now, so for this time it doesn't matter any more.)
emacs-bbdb-2.35-8.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.