Bug 835937 - virsh freecell accepts non-numeric cellno
Summary: virsh freecell accepts non-numeric cellno
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: libvirt
Version: 5.8
Hardware: Unspecified
OS: Linux
unspecified
low
Target Milestone: rc
: ---
Assignee: Libvirt Maintainers
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-27 15:01 UTC by Chris Evich
Modified: 2012-06-28 03:13 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-27 15:06:17 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Chris Evich 2012-06-27 15:01:37 UTC
Description of problem:
virsh happily accepts a non-numeric (e.g. 'xyz') cellno assuming it to be 0.  Later versions (RHEL 6+) flag this as an error.

Version-Release number of selected component (if applicable):
libvirt-0.8.2-25.el5

How reproducible:
Easy

Steps to Reproduce:
1. virsh freecell xyz
  
Actual results:
# virsh freecell xyz
0: 3024308 kB


Expected results:
# virsh freecell xyz
error: cell number has to be a number

Additional info:
Discovered this with a new 'freecell' test on libvirt autotest, However problem is easily reproducable by hand.  It's a very minor issue, but filling it anyway in case it's an easy fix.

Comment 1 Eric Blake 2012-06-27 15:06:17 UTC
It may be an easy fix, but backporting introduces risk, and since the problem only occurs on invalid input and only impacts virsh, you are better off passing valid input rather than asking us to backport a fix.  At this point, we want to backport as little as possible into RHEL 5, focusing purely on bugs that have a larger impact to libvirtd itself.  I'm marking this as WONTFIX.

Comment 2 Chris Evich 2012-06-27 15:18:49 UTC
Understood, and fair enough.  Thanks for taking a look.


Note You need to log in before you can comment on or make changes to this bug.