RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 836275 - qemu-ga: change on fsfreeze semantics when compared to RHEL6
Summary: qemu-ga: change on fsfreeze semantics when compared to RHEL6
Keywords:
Status: CLOSED DUPLICATE of bug 831174
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: qemu-kvm
Version: 7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: pre-dev-freeze
: 7.0
Assignee: Luiz Capitulino
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 831387
TreeView+ depends on / blocked
 
Reported: 2012-06-28 14:35 UTC by Luiz Capitulino
Modified: 2012-10-26 17:11 UTC (History)
10 users (show)

Fixed In Version: 1.3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-10-25 13:51:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Luiz Capitulino 2012-06-28 14:35:25 UTC
During the review process of the patches which updated qemu-ga to its latest upstream version (which is v1.1), it was identified some semantics changes of the file-system freeze process that may be undesirable or even cause regressions.

The changes are:

o qmp-guest-fsfreeze-freeze can be called even if the FS is already frozen (by qmp-guest-fsfreeze itself). Before, qmp-guest-fsfreeze couldn't be called twice in a row (a call to qmp-guest-fsfreeze-freeze had to match a call to qmp-guest-fsfreeze-thaw)

o qmp-guest-fsfreeze-thaw re-builds the FS list to be thawed every time it's called, this means that it will see file-system changes between freeze and thaw (ie. if a new FS "appears", it will be thawed). Before, qmp-guest-fsfreeze-thaw would only thaw the file-systems frozen by qmp-guest-fsfreeze-freeze

o qmp-guest-fsfreeze-thaw will thaw each file-system in a loop, meaning that it will thaw all file-system, regardless if they were thawed by another processes. Also, the loop makes it impossible to report errors. Before, qmp-guest-fsfreeze-thaw would thaw a file-system only once

All these issues have to be discussed upstream and if we decide to fix any of them the fixes have to be backported to 6.4.

Comment 1 Ademar Reis 2012-06-28 17:43:10 UTC
As far as RHEL is concerned, qemu-ga was tech-preview in RHEL6.3 and such a change in behavior is not a problem. But indeed, if they're "fixed" upstream, a backport to RHEL6.4 will be required.

Comment 2 juzhang 2012-07-19 03:40:29 UTC
QE will do viragent funcational in order to not bring regression after this issue is fixed

Comment 4 Paolo Bonzini 2012-10-25 13:31:49 UTC
Fixed in upstream commit 6a3c8c14c8467c5db3539f1b6e43e03318e5e21b.

Comment 5 Paolo Bonzini 2012-10-25 13:51:00 UTC

*** This bug has been marked as a duplicate of bug 831174 ***

Comment 6 Luiz Capitulino 2012-10-26 13:12:04 UTC
Paolo, I don't understand how moving the freeze state file solves this bz?

Actually, I also think this should be closed but for a different reason: it's probably too late to change those semantics again (unless they are buggy).

Comment 7 Paolo Bonzini 2012-10-26 14:52:57 UTC
The fix for the problems in comment 0 was to move the state file.  Upstream places the freeze state file in the same place as RHEL6, so there will be no change in fsfreeze semantics from RHEL6 to RHEL7.

Comment 8 Luiz Capitulino 2012-10-26 17:11:11 UTC
Makes sense.


Note You need to log in before you can comment on or make changes to this bug.