Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-cinch.spec SRPM URL: http://mcpierce.fedorapeople.org/rpms/rubygem-cinch-2.0.3-1.fc17.src.rpm Description: A simple, friendly DSL for creating IRC bots. Fedora Account System Username: mcpierce
This is an unofficial practice review. Rpmlint: - Found "wrong-file-end-of-line-encoding" warnings - Found "unexpanded-macro" warnings - Found one "file-not-utf8" warning Considering these ignorable based on: https://bugzilla.redhat.com/show_bug.cgi?id=721057 https://bugzilla.redhat.com/show_bug.cgi?id=786249 Package Review: - package meets package naming guidelines - package meets Ruby guidelines - base package name matches spec name - legible and in American English - license MIT is okay - license file included in %doc section - MD5 sum on tarball matches that of the upstream tarball - no missing BuildRequires - the "ruby" and "ruby(abi)" BuildRequires are not necessary - the "ruby" Requires is not necessary - no locales included - not a relocatable package - owns all directories it creates - no duplicate files in %files section and all file names are valid utf-8 - file timestamps are okay, using "cp -a" - consistent macro use - includes -docs subpackage for documentation - no files in %doc section are executable - no bundled system libraries - no development files - no static libraries - no need for .desktop file - builds on x86 successfully in mock - running example irc bot from examples directory worked - no man pages, though it has ruby documentation files Fixes: - remove "ruby" and "ruby(abi)" BuildRequires - remove "ruby" Requires
I'd fix the utf-8 and EOL encoding warnings.
(In reply to comment #2) > I'd fix the utf-8 and EOL encoding warnings. The utf-8 complaint is about the cache.ri file which is binary, not text. The EOL warnings are also against .ri files, which are binary as well.
Odd. Nevermind, then. :)
Looks like I am a packager now, so I'll make this an official review. Please make the fixes listed in my review above and that should be good enough.
(In reply to comment #5) > Looks like I am a packager now, so I'll make this an official review. Please > make the fixes listed in my review above and that should be good enough. Thank you, and congrats. :) The Requires and BuildRequires fields are removed. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-cinch.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-cinch-2.0.3-1.fc17.1.src.rpm
Ok, everything here looks good to me. Approved!
(In reply to comment #7) > Ok, everything here looks good to me. > > Approved! Thank you. :) New Package SCM Request ======================= Package Name: rubygem-cinch Short Description: An IRC Bot Building Framework Owners: mcpierce Branches: f17 f18 InitialCC: mcpierce
@Darryl: would you mind to execute the cinch's test suite? Although I'm not sure if that is possible due to the network nature of the gem. (In reply to comment #5) > Looks like I am a packager now, so I'll make this an official review. Please > make the fixes listed in my review above and that should be good enough. Hi Matt, the issue should be in assigned state and you should be assignee ATM.
New Package SCM Request ======================= Package Name: rubygem-cinch Short Description: An IRC Bot Building Framework Owners: mcpierce Branches: f17 f18 InitialCC: mcpierce
Git done (by process-git-requests). NOTE: we aren't doing f18 branches yet.
Thank you, Kevin. :)