Red Hat Bugzilla – Bug 836624
buildbot rpmlint step does not save search path
Last modified: 2013-08-11 08:36:35 EDT
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
The RpmLint test step that comes with the buildbot package does not correctly save its "fileloc" search pattern, so when it executes on the build slave it always uses the default pattern "*rpm".
Steps to Reproduce:
1. Add a factory with an RpmLint step for a unique RPM path (e.g. "dist/*/*.rpm").
2. Observe the command string in the buildbot log for that step. The command line indicates the call ["/usr/bin/rpmlint", "-i", "*rpm"], which is not what is desired.
3. Observe that the step may fail to locate RPM files to check.
The test step may not actually test any RPM files, in which case the test will falsely pass.
The test step should scan the desired file pattern.
Created attachment 595340 [details]
A proposed change which fixes the issue.
This patch follows the behavior of other test steps, but I'm not exactly sure that "addFactoryArguments" is the correct way to register the custom parameters.
This message is a reminder that Fedora 17 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 17. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora
'version' of '17'.
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version prior to Fedora 17's end of life.
Bug Reporter: Thank you for reporting this issue and we are sorry that
we may not be able to fix it before Fedora 17 is end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora, you are encouraged change the
'version' to a later Fedora version prior to Fedora 17's end of life.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
Fedora 17 changed to end-of-life (EOL) status on 2013-07-30. Fedora 17 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.
If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version.
Thank you for reporting this bug and we are sorry it could not be fixed.
A derivative of this patch is merged upstream in
Brian, if you need it before the next version lands, feel free to open a new bugzilla ticket asking to add that patch to the package.