Spec URL: http://subversion.city-fan.org/repos/cfo-repo/libpari23/branches/fedora/libpari23.spec SRPM URL: http://www.city-fan.org/~paul/extras/pari/libpari23-2.3.5-1.fc18.src.rpm Description: PARI is a widely used computer algebra system designed for fast computations in number theory (factorizations, algebraic number theory, elliptic curves...), but also contains a large number of other useful functions to compute with mathematical entities such as matrices, polynomials, power series, algebraic numbers, etc., and a lot of transcendental functions. This is an old version of the library, for compatibility with applications and library bindings that have not been migrated to the current stable release. Fedora Account System Username: pghmcfc
Building on an installed system (to check for possible conflicts), not a buildroot I got this: RPM build errors: Installed (but unpackaged) file(s) found: /usr/share/emacs/site-lisp/pari/pari-completion.el /usr/share/emacs/site-lisp/pari/pari-completion.elc /usr/share/emacs/site-lisp/pari/pari-conf.el /usr/share/emacs/site-lisp/pari/pari-conf.elc /usr/share/emacs/site-lisp/pari/pari-fontification.el /usr/share/emacs/site-lisp/pari/pari-fontification.elc /usr/share/emacs/site-lisp/pari/pari-help.el /usr/share/emacs/site-lisp/pari/pari-messages.el /usr/share/emacs/site-lisp/pari/pari-messages.elc /usr/share/emacs/site-lisp/pari/pari.el /usr/share/emacs/site-lisp/pari/pari.elc /usr/share/emacs/site-lisp/pari/pariemacs.txt /usr/share/emacs/site-lisp/pari/sli-tools.el /usr/share/emacs/site-lisp/pari/sli-tools.elc I suggest something like: $ diff -u SPECS/libpari23.spec 837004/libpari23.spec --- SPECS/libpari23.spec 2012-07-02 09:09:50.000000000 -0400 +++ 837004/libpari23.spec 2012-07-02 11:31:53.768642232 -0400 @@ -118,6 +118,9 @@ # Placate rpmlint regarding binary and library permissions %{_fixperms} %{buildroot}{%{_bindir},%{_libdir}} +# Cleanup emacs in alternate package rm -fr %{buildroot}%{_datadir}/emacs + %check make dobench make dotest-compat After the above, you will need to update perl-Math-Pari.spec, to avoid $ rpmbuild -ba SPECS/perl-Math-Pari.spec error: Failed build dependencies: pari-devel = 2.3.5 is needed by perl-Math-Pari-2.010806-13.fc18.x86_64 somewhat like: $ diff -u SPECS/perl-Math-Pari.spec{~,} --- SPECS/perl-Math-Pari.spec~ 2012-07-02 11:35:37.129650783 -0400 +++ SPECS/perl-Math-Pari.spec 2012-07-02 11:36:57.368653861 -0400 @@ -30,7 +30,7 @@ Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) # Enforce dependency against same version of pari that we're built for -BuildRequires: pari-devel = %{pari_version} +BuildRequires: libpari23-devel Requires: pari%{?_isa} = %{pari_version} # Don't "provide" private Perl libs or the redundant unversioned perl(Math::Pari) after the above, I only did need: $ diff -u SPECS/perl-Math-Pari.spec{.orig,} --- SPECS/perl-Math-Pari.spec.orig 2012-07-02 11:36:57.368653861 -0400 +++ SPECS/perl-Math-Pari.spec 2012-07-02 11:40:12.704661293 -0400 @@ -62,8 +62,8 @@ %build perl Makefile.PL \ INSTALLDIRS=vendor \ - OPTIMIZE="-I%{_includedir}/pari %{optflags}" \ - parilib="-lpari" + OPTIMIZE="-I%{_includedir}/libpari23/pari %{optflags}" \ + parilib="-lpari23" make %{?_smp_mflags} %install
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST ldconfig called in %post and %postun if required. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. [x]: MUST Development (unversioned) .so files in -devel subpackage, if present. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) Note: Only applicable for EL-5 [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint libpari23-2.3.5-1.fc18.i686.rpm libpari23.i686: W: spelling-error %description -l en_US factorizations -> factorization, factorization s, categorizations libpari23.i686: E: shlib-with-non-pic-code /usr/lib/libpari-gmp.so.2.3.5 libpari23.i686: W: shared-lib-calls-exit /usr/lib/libpari-gmp.so.2.3.5 exit libpari23.i686: E: incorrect-fsf-address /usr/share/doc/libpari23-2.3.5/COPYING 1 packages and 0 specfiles checked; 2 errors, 2 warnings. rpmlint libpari23-debuginfo-2.3.5-1.fc18.i686.rpm libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/graph/plotport.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/errmsg.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/parierr.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/alglin2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/gen1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/gmp/mp.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/buch2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/subcyclo.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paridecl.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/mulll.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/gen3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/elldata.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/aprcl.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/add.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/gp_init.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/trans2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/kummer.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/arith1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/ratlift.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/ifactor1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/gcdll.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/intnum.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/level1.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/compat.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/gmp/gcd.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/whatnow.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/groupid.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/elliptic.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/buch1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/trans1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/bfffo.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/buch3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/cmp.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/members.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/parigen.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/trans3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paricom.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/thue.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/subgroup.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/graph/rect.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/bibli2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/mpqs.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/sumiter.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/nffactor.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/buch4.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/rootpol.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/default.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paripriv.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/addll.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/perm.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/init.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/subfield.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/stark.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/gp.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/anal.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/highlvl.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/gp_rl.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base5.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/polarit1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/Qfb.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/bibli1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/polarit3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/gp.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paritype.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/divll.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/invmod.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/parinf.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/graph/plotX.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/mp_indep.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/alglin1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base4.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/RgX.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/es.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/polarit2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/gen2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/galois.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/part.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/Flx.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paristio.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/mpinl.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/galconj.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/arith2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/anal.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base2.c 1 packages and 0 specfiles checked; 86 errors, 0 warnings. rpmlint libpari23-2.3.5-1.fc18.src.rpm libpari23.src: W: spelling-error %description -l en_US factorizations -> factorization, factorization s, categorizations libpari23.src:93: E: hardcoded-library-path in %{_prefix}/lib/pari 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint libpari23-devel-2.3.5-1.fc18.i686.rpm libpari23-devel.i686: W: no-documentation libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/pariport.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/pari.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/language/anal.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paricom.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/libpari.toc libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/parigen.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/qfbsolve libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/parierr.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/pariport.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/parierr.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/test/tune.c libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.idx libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/tutorial.idx libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paritype.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paristio.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paripriv.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.aux libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/doc/gphelp libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/pariold.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/parigen.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/users.toc libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/pari.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/parisys.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paridecl.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/parinf.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/parinf.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/pariold.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/rfrac libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paripriv.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paricast.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.toc libpari23-devel.i686: E: wrong-script-interpreter /usr/share/libpari23/doc/gphelp.in @perl@ libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/doc/gphelp.in libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/gp/gp.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paridecl.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paricast.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.aux libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/parisys.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paritype.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paricom.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paristio.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/graph/rect.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/pariinl.h 1 packages and 0 specfiles checked; 43 errors, 1 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/pcpa/rpmbuild/837004/pari-2.3.5.tar.gz : MD5SUM this package : 6077c6db56fdd32e39a06a9bf320e1f7 MD5SUM upstream package : 6077c6db56fdd32e39a06a9bf320e1f7 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [-]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SHOULD The placement of pkgconfig(.pc) files are correct. [x]: SHOULD Scriptlets must be sane, if used. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0: http://pari.math.u-bordeaux.fr/pub/pari/unix/OLD/pari-%{version}.tar.gz (pari-%{version}.tar.gz) Patch1: libpari23-optflags.patch (libpari23-optflags.patch) Patch2: Math-Pari-2.01080604-extra-stack-for- test.patch (Math-Pari-2.01080604-extra-stack-for-test.patch) [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) Note: Only applicable for EL-5 See: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5 [!]: MUST Rpmlint output is silent. rpmlint libpari23-2.3.5-1.fc18.i686.rpm libpari23.i686: W: spelling-error %description -l en_US factorizations -> factorization, factorization s, categorizations libpari23.i686: E: shlib-with-non-pic-code /usr/lib/libpari-gmp.so.2.3.5 libpari23.i686: W: shared-lib-calls-exit /usr/lib/libpari-gmp.so.2.3.5 exit libpari23.i686: E: incorrect-fsf-address /usr/share/doc/libpari23-2.3.5/COPYING 1 packages and 0 specfiles checked; 2 errors, 2 warnings. rpmlint libpari23-debuginfo-2.3.5-1.fc18.i686.rpm libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/graph/plotport.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/errmsg.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/parierr.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/alglin2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/gen1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/gmp/mp.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/buch2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/subcyclo.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paridecl.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/mulll.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/gen3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/elldata.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/aprcl.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/add.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/gp_init.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/trans2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/kummer.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/arith1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/ratlift.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/ifactor1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/gcdll.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/intnum.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/level1.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/compat.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/gmp/gcd.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/whatnow.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/groupid.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/elliptic.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/buch1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/trans1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/bfffo.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/buch3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/cmp.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/members.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/parigen.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/trans3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paricom.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/thue.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/subgroup.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/graph/rect.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/bibli2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/mpqs.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/sumiter.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/nffactor.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/buch4.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/rootpol.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/default.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paripriv.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/addll.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/perm.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/init.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/subfield.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/stark.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/gp.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/anal.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/highlvl.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/gp_rl.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base5.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/polarit1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/Qfb.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/bibli1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/polarit3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/gp/gp.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paritype.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/divll.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base3.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/invmod.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/parinf.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/graph/plotX.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/mp_indep.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/alglin1.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base4.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/RgX.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/es.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/polarit2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/gen2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/galois.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/modules/part.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/Flx.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/headers/paristio.h libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/kernel/none/mpinl.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/galconj.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/arith2.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/language/anal.c libpari23-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/pari-2.3.5/src/basemath/base2.c 1 packages and 0 specfiles checked; 86 errors, 0 warnings. rpmlint libpari23-2.3.5-1.fc18.src.rpm libpari23.src: W: spelling-error %description -l en_US factorizations -> factorization, factorization s, categorizations libpari23.src:93: E: hardcoded-library-path in %{_prefix}/lib/pari 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint libpari23-devel-2.3.5-1.fc18.i686.rpm libpari23-devel.i686: W: no-documentation libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/pariport.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/pari.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/language/anal.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paricom.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/libpari.toc libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/parigen.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/qfbsolve libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/parierr.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/pariport.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/parierr.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/test/tune.c libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.idx libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/tutorial.idx libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paritype.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paristio.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paripriv.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.aux libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/doc/gphelp libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/pariold.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/parigen.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/users.toc libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/pari.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/parisys.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paridecl.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/parinf.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/parinf.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/pariold.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/rfrac libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paripriv.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paricast.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.toc libpari23-devel.i686: E: wrong-script-interpreter /usr/share/libpari23/doc/gphelp.in @perl@ libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/doc/gphelp.in libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/gp/gp.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paridecl.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paricast.h libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.aux libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/parisys.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paritype.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/paricom.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/headers/paristio.h libpari23-devel.i686: E: incorrect-fsf-address /usr/share/libpari23/src/graph/rect.h libpari23-devel.i686: E: incorrect-fsf-address /usr/include/libpari23/pari/pariinl.h 1 packages and 0 specfiles checked; 43 errors, 1 warnings. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Generated by fedora-review 0.1.3 External plugins:
In libpari23.spec only %clean should be an issue. (Note, I did not add any "!" they were filled by fedora-review)
Ops, doing my homework, updating flags and assigning to myself. Waiting for some information (actually, only I am only concerned about %clean) to change from review-? to review-+ But I think there may be issues with the libpari23.pc file, e.g. includes are under %{_includedir}/libpari23/pari and I think most code using pari does not include "pari/name.h" but "name.h" BTW, yet another issue, also in pari.spec, is that pari.cfg should not be marked %doc. But not a big issue, as I believe no code linking to pari cares about it.
(In reply to comment #1) > Building on an installed system (to check for possible conflicts), not a > buildroot I got this: > > RPM build errors: > Installed (but unpackaged) file(s) found: > /usr/share/emacs/site-lisp/pari/pari-completion.el > /usr/share/emacs/site-lisp/pari/pari-completion.elc > /usr/share/emacs/site-lisp/pari/pari-conf.el > /usr/share/emacs/site-lisp/pari/pari-conf.elc > /usr/share/emacs/site-lisp/pari/pari-fontification.el > /usr/share/emacs/site-lisp/pari/pari-fontification.elc > /usr/share/emacs/site-lisp/pari/pari-help.el > /usr/share/emacs/site-lisp/pari/pari-messages.el > /usr/share/emacs/site-lisp/pari/pari-messages.elc > /usr/share/emacs/site-lisp/pari/pari.el > /usr/share/emacs/site-lisp/pari/pari.elc > /usr/share/emacs/site-lisp/pari/pariemacs.txt > /usr/share/emacs/site-lisp/pari/sli-tools.el > /usr/share/emacs/site-lisp/pari/sli-tools.elc > > I suggest something like: > $ diff -u SPECS/libpari23.spec 837004/libpari23.spec > --- SPECS/libpari23.spec 2012-07-02 09:09:50.000000000 -0400 > +++ 837004/libpari23.spec 2012-07-02 11:31:53.768642232 -0400 > @@ -118,6 +118,9 @@ > # Placate rpmlint regarding binary and library permissions > %{_fixperms} %{buildroot}{%{_bindir},%{_libdir}} > > +# Cleanup emacs in alternate package > rm -fr %{buildroot}%{_datadir}/emacs > + I've added something like this in -2. > After the above, you will need to update perl-Math-Pari.spec, to avoid > $ rpmbuild -ba SPECS/perl-Math-Pari.spec > error: Failed build dependencies: > pari-devel = 2.3.5 is needed by > perl-Math-Pari-2.010806-13.fc18.x86_64 > > somewhat like: > $ diff -u SPECS/perl-Math-Pari.spec{~,} > --- SPECS/perl-Math-Pari.spec~ 2012-07-02 11:35:37.129650783 -0400 > +++ SPECS/perl-Math-Pari.spec 2012-07-02 11:36:57.368653861 -0400 > @@ -30,7 +30,7 @@ > Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo > $version)) > > # Enforce dependency against same version of pari that we're built for > -BuildRequires: pari-devel = %{pari_version} > +BuildRequires: libpari23-devel > Requires: pari%{?_isa} = %{pari_version} > > # Don't "provide" private Perl libs or the redundant unversioned > perl(Math::Pari) > > after the above, I only did need: > $ diff -u SPECS/perl-Math-Pari.spec{.orig,} > --- SPECS/perl-Math-Pari.spec.orig 2012-07-02 11:36:57.368653861 -0400 > +++ SPECS/perl-Math-Pari.spec 2012-07-02 11:40:12.704661293 -0400 > @@ -62,8 +62,8 @@ > %build > perl Makefile.PL \ > INSTALLDIRS=vendor \ > - OPTIMIZE="-I%{_includedir}/pari %{optflags}" \ > - parilib="-lpari" > + OPTIMIZE="-I%{_includedir}/libpari23/pari %{optflags}" \ > + parilib="-lpari23" > make %{?_smp_mflags} I've got a re-worked perl-Math-Pari package here, with quite a few changes for moving to libpari23: http://www.city-fan.org/~paul/extras/pari/perl-Math-Pari-2.010806-14.fc18.src.rpm (In reply to comment #2) > [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: Clean is needed only if supporting EPEL Fixed in -2 > [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at > the > beginning of %install. Fixed in -2 > [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) > Note: Only applicable for EL-5 Didn't remove the explicit requirement here - I think it's harmless anyway. > [!]: MUST Rpmlint output is silent. > > rpmlint libpari23-2.3.5-1.fc18.i686.rpm > > libpari23.i686: W: spelling-error %description -l en_US factorizations -> > factorization, factorization s, categorizations False positive. > libpari23.i686: E: shlib-with-non-pic-code /usr/lib/libpari-gmp.so.2.3.5 Fixed in -2 > libpari23.i686: W: shared-lib-calls-exit /usr/lib/libpari-gmp.so.2.3.5 > exit That's one for upstream > libpari23.i686: E: incorrect-fsf-address > /usr/share/doc/libpari23-2.3.5/COPYING Not allowed to change that for legal reasons. Already fixed in upstream VCS. > rpmlint libpari23-debuginfo-2.3.5-1.fc18.i686.rpm > > libpari23-debuginfo.i686: E: incorrect-fsf-address > /usr/src/debug/pari-2.3.5/src/graph/plotport.c These are all fixed in -2 > rpmlint libpari23-2.3.5-1.fc18.src.rpm > > libpari23.src: W: spelling-error %description -l en_US factorizations -> > factorization, factorization s, categorizations False positive again > libpari23.src:93: E: hardcoded-library-path in %{_prefix}/lib/pari The place where this happens is where we remove files that upstream has put there. > rpmlint libpari23-devel-2.3.5-1.fc18.i686.rpm > > libpari23-devel.i686: W: no-documentation There but it's not marked as %doc as it's needed by other packages so we don't want it omitted when installed using --nodocs > libpari23-devel.i686: E: incorrect-fsf-address > /usr/share/libpari23/src/headers/pariport.h These are all fixed in -2 > libpari23-devel.i686: E: zero-length > /usr/share/libpari23/src/test/32/qfbsolve > libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/rfrac I think these are intentionally zero length > libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/libpari.toc > libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.idx > libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/tutorial.idx > libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.aux > libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/users.toc > libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.toc > libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.aux This is all fall-out from the tex documentation build; not sure if omitting them would cause problems for downstream users (Math::Pari builds its own POD documentation from the tex files). > libpari23-devel.i686: E: wrong-script-interpreter > /usr/share/libpari23/doc/gphelp.in @perl@ This is intended to be substituted by downstream users. > [-]: SHOULD Latest version is packaged. This is intentionally not the latest version, for compatibility reasons. > [!]: SHOULD SourceX / PatchY prefixed with %{name}. > Note: Source0: > http://pari.math.u-bordeaux.fr/pub/pari/unix/OLD/pari-%{version}.tar.gz > (pari-%{version}.tar.gz) Patch1: libpari23-optflags.patch > (libpari23-optflags.patch) Patch2: Math-Pari-2.01080604-extra-stack-for- > test.patch (Math-Pari-2.01080604-extra-stack-for-test.patch) Patch2 has origins in the perl-Math-Pari package, hence its prefix. > Issues: > [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: Clean is needed only if supporting EPEL > See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean > [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at > the > beginning of %install. > Note: rm -rf is only needed if supporting EPEL5 > See: None > [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) > Note: Only applicable for EL-5 > See: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5 > [!]: MUST Rpmlint output is silent. I think these are addressed in -2 as described above. Spec URL: http://subversion.city-fan.org/repos/cfo-repo/libpari23/branches/fedora/libpari23.spec SRPM URL: http://www.city-fan.org/~paul/extras/pari/libpari23-2.3.5-2.fc18.src.rpm (In reply to comment #4) > Ops, doing my homework, updating flags and assigning to myself. > Waiting for some information (actually, only I am only concerned about > %clean) to change from review-? to review-+ > > But I think there may be issues with the libpari23.pc file, e.g. > > includes are under %{_includedir}/libpari23/pari and I think most code using > pari does not include "pari/name.h" but "name.h" This applies for perl-Math-Pari for instance. However, upstream's API documentation for the current release says to use <pari/pari.h>, which is why I went the way I did. Looking back at older documentation, it seems this has changed since 2.3.0 where the recommendation was just <pari.h> so I'm open to changing it but I don't think it's a big deal. > BTW, yet another issue, also in pari.spec, is that pari.cfg should not be > marked %doc. But not a big issue, as I believe no code linking to pari cares > about it. That's what I thought too, which is why I just included in %{_docdir} rather than under %{_sysconfdir}.
[...] > I've got a re-worked perl-Math-Pari package here, with quite a few changes > for moving to libpari23: > http://www.city-fan.org/~paul/extras/pari/perl-Math-Pari-2.010806-14.fc18. > src.rpm Builds cleanly now. [...] > > BTW, yet another issue, also in pari.spec, is that pari.cfg should not be > > marked %doc. But not a big issue, as I believe no code linking to pari cares > > about it. > > That's what I thought too, which is why I just included in %{_docdir} rather > than under %{_sysconfdir}. I think it may be required to revisit it at some point for sagemath, like it does for polybori's /usr/share/polybori/flags.conf, but the pkconfig file should be good enough.
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST ldconfig called in %post and %postun if required. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. [x]: MUST Package is not relocatable. [x]: MUST Development (unversioned) .so files in -devel subpackage, if present. ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) Note: Only applicable for EL-5 [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint libpari23-2.3.5-2.fc18.src.rpm libpari23.src: W: spelling-error %description -l en_US factorizations -> factorization, factorization s, categorizations libpari23.src:96: E: hardcoded-library-path in %{_prefix}/lib/pari 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint libpari23-debuginfo-2.3.5-2.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint libpari23-2.3.5-2.fc18.i686.rpm libpari23.i686: W: spelling-error %description -l en_US factorizations -> factorization, factorization s, categorizations libpari23.i686: W: shared-lib-calls-exit /usr/lib/libpari-gmp.so.2.3.5 exit libpari23.i686: E: incorrect-fsf-address /usr/share/doc/libpari23-2.3.5/COPYING 1 packages and 0 specfiles checked; 1 errors, 2 warnings. rpmlint libpari23-devel-2.3.5-2.fc18.i686.rpm libpari23-devel.i686: W: no-documentation libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/libpari.toc libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/qfbsolve libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.idx libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/tutorial.idx libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.aux libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/users.toc libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/rfrac libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.toc libpari23-devel.i686: E: wrong-script-interpreter /usr/share/libpari23/doc/gphelp.in @perl@ libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.aux 1 packages and 0 specfiles checked; 10 errors, 1 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/pcpa/rpmbuild/837004/pari-2.3.5.tar.gz : MD5SUM this package : 6077c6db56fdd32e39a06a9bf320e1f7 MD5SUM upstream package : 6077c6db56fdd32e39a06a9bf320e1f7 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [-]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SHOULD The placement of pkgconfig(.pc) files are correct. [x]: SHOULD Scriptlets must be sane, if used. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0: http://pari.math.u-bordeaux.fr/pub/pari/unix/OLD/pari-%{version}.tar.gz (pari-%{version}.tar.gz) Patch1: libpari23-optflags.patch (libpari23-optflags.patch) Patch2: libpari23-fsf-address.patch (libpari23 -fsf-address.patch) Patch3: Math-Pari-2.01080604-extra-stack-for- test.patch (Math-Pari-2.01080604-extra-stack-for-test.patch) [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Package requires pkgconfig, if .pc files are present. (EPEL5) Note: Only applicable for EL-5 See: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5 [!]: MUST Rpmlint output is silent. rpmlint libpari23-2.3.5-2.fc18.src.rpm libpari23.src: W: spelling-error %description -l en_US factorizations -> factorization, factorization s, categorizations libpari23.src:96: E: hardcoded-library-path in %{_prefix}/lib/pari 1 packages and 0 specfiles checked; 1 errors, 1 warnings. rpmlint libpari23-debuginfo-2.3.5-2.fc18.i686.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint libpari23-2.3.5-2.fc18.i686.rpm libpari23.i686: W: spelling-error %description -l en_US factorizations -> factorization, factorization s, categorizations libpari23.i686: W: shared-lib-calls-exit /usr/lib/libpari-gmp.so.2.3.5 exit libpari23.i686: E: incorrect-fsf-address /usr/share/doc/libpari23-2.3.5/COPYING 1 packages and 0 specfiles checked; 1 errors, 2 warnings. rpmlint libpari23-devel-2.3.5-2.fc18.i686.rpm libpari23-devel.i686: W: no-documentation libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/libpari.toc libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/qfbsolve libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.idx libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/tutorial.idx libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.aux libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/users.toc libpari23-devel.i686: E: zero-length /usr/share/libpari23/src/test/32/rfrac libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/develop.toc libpari23-devel.i686: E: wrong-script-interpreter /usr/share/libpari23/doc/gphelp.in @perl@ libpari23-devel.i686: E: zero-length /usr/share/libpari23/doc/refcard.aux 1 packages and 0 specfiles checked; 10 errors, 1 warnings. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Generated by fedora-review 0.1.3 External plugins: ---%<---%<---%<--- I consider the package approved, and the fedora-review generated errors false positives, and harmless (e.g. spell errors, empty files and EPEL5 issues).
New Package SCM Request ======================= Package Name: libpari23 Short Description: Number Theory-oriented Computer Algebra Library Owners: pghmcfc
Git done (by process-git-requests).
Build done. Thanks for the review. I'll update perl-Math-Pari and pari itself shortly.