Spec URL: http://bkabrda.fedorapeople.org/pkgs/ruby-libvirt/rubygem-ruby-libvirt.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/ruby-libvirt/rubygem-ruby-libvirt-0.4.0-1.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4213157 Description: Ruby bindings for libvirt. Fedora Account System Username: bkabrda
Please note, that I have already asked upstream to fix the rpmlint warning about outdated license file: https://bugzilla.redhat.com/show_bug.cgi?id=837006
Can you also remove the "-ruby-" from the package name since it's redundant?
(In reply to comment #2) > Can you also remove the "-ruby-" from the package name since it's redundant? No, I don't think that's a good idea, as there is a "libvirt" gem [1] - and if we ever need to package it, this would turn out to be a problem. [1] https://rubygems.org/gems/libvirt
I'll take it for a review.
* Forgotten TODO? - Your spec file contains "# TODO: move the extensions". Seems to be some relict? * Disabled test suite - Sad to see test suite disabled. Have you tried to confirm with upstream that root privileges are really needed?(In reply to comment #3) These comments are just minor nits. I see no other issues => APPROVED
Thank you for the review! (In reply to comment #5) > * Forgotten TODO? > - Your spec file contains "# TODO: move the extensions". Seems to be some > relict? > Yep, I forgot it there. I will remove it before importing into dist-git. > * Disabled test suite > - Sad to see test suite disabled. Have you tried to confirm with upstream > that > root privileges are really needed?(In reply to comment #3) > The tests directly communicate with libvirt, for which you always needs to be superuser. Moreover, there are some system files modified in /etc. Without it, tests would have no meaning, everything would need to be mocked. > These comments are just minor nits. I see no other issues => APPROVED New Package SCM Request ======================= Package Name: rubygem-ruby-libvirt Short Description: Ruby bindings for LIBVIRT Owners: bkabrda Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ====================== Package Name: rubygem-ruby-libvirt New Branches: epel7 Owners: tdawson