Red Hat Bugzilla – Bug 837048
irqbalance ONESHOT configuration not implemented properly
Last modified: 2016-10-04 00:08:18 EDT
Description of problem: When irqbalance was converted to systemd, the ONESHOT
configuration variable was not converted properly. In /etc/sysconfig/irqbalance,
it suggests setting ONESHOT to yes to enable that feature. But
the /lib/systemd/system/irqbalance.service file simply passes this argument
to irqbalance, which will not understand an argument of "yes".
Version-Release number of selected component (if applicable):
How reproducible: Try setting ONESHOT to yes in /etc/sysconfig/irqbalance
Steps to Reproduce:
1. Look at /etc/sysconfig/irqbalance and /lib/systemd/system/irqbalance.service and observe that ONESHOT is not implemented properly.
Additional info: The simplest fix is probably to edit /etc/sysconfig/irqbalance to suggest setting ONESHOT to --oneshot if that behavior
yup, Andrew is correct. That should definately be fixed. I'd recommend however, instead of using the --oneshot mechanism, we convert the sysconfig file to set IRQBALANCE_ONESHOT, and just remove the $ONESHOT from the unit file.
Since it may be desirable to pass other arguments to irqbalance,
such as --powerthresh=1 or --shouldban=/usr/sbin/irqban.sh, would it make
sense simply to have IRQBALANCE_ARGS in the sysconfig and systemd files?
Also, I think IRQ_AFFINITY_MASK is obsolete.
Yes, it would make sense to have an IRQBALANCE_ARGS environment variable that we can use to pass args to the daemon, I'll add that upstream, and petr can pull it in here (right after I finish with the banscript work, which I hope should be tomorrow).
And yes, IRQ_AFFINTY_MASK is obsolete. Its been removed from upstream for some time now, and should be removed in fedora. Petr, can you square that up please?
Ok, I will sync it with upstream in the next release during this week.
irqbalance-1.0.3-6.fc18 has been submitted as an update for Fedora 18.
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing irqbalance-1.0.3-6.fc18'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
irqbalance-1.0.3-7.fc18 has been submitted as an update for Fedora 18.
irqbalance-1.0.3-8.fc18 has been submitted as an update for Fedora 18.
irqbalance-1.0.3-8.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.