Hide Forgot
Spec URL: http://fedorapeople.org/~jskarvad/nacl/nacl.spec SRPM URL: http://fedorapeople.org/~jskarvad/nacl/nacl-20110221-1.fc17.src.rpm Description: NaCl (pronounced "salt") is a new easy-to-use high-speed software library for network communication, encryption, decryption, signatures, etc. NaCl's goal is to provide all of the core operations needed to build higher-level cryptographic tools. Fedora Account System Username: jskarvad - I would like to use this library in netsniff-ng package. - nacl-20110221-noexec-stack.patch was sent upstream. - Currently there is included reference implementation of curvecp (http://curvecp.org/) in the sources. From upstream doc: "CurveCP software isn't ready for users yet but is ready for experimentation and development by interested programmers.". So I let it there as is. We could also remove it entirely or build standalone curvecp RPM package from the sources. Any ideas are welcome.
Issues: [!]: MUST Static libraries in -static subpackage, if present. Note: nacl-devel-20110221-1.fc17.x86_64.rpm : /usr/lib64/libnacl.a See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries [!]: EXTRA Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). Diff spec file in url and in SRPM --------------------------------- --- /home/jsynacek/work/reviews/nacl.spec 2012-09-03 12:39:55.432557126 +0200 +++ /home/jsynacek/work/reviews/nacl/srpm-unpacked/nacl.spec 2012-09-03 12:42:23.269591873 +0200 @@ -1,5 +1,4 @@ Name: nacl -# http://nacl.cr.yp.to/ -URL: http://nacl.cace-project.eu/ +URL: http://nacl.cr.yp.to/ Version: 20110221 Release: 1%{?dist} Requires
(In reply to comment #1) > Issues: > [!]: MUST Static libraries in -static subpackage, if present. > Note: nacl-devel-20110221-1.fc17.x86_64.rpm : /usr/lib64/libnacl.a > See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries > Probably OK, from http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries: ... There are two scenarios in which static libraries are packaged: ... 2. Static libraries only. When a package only provides static libraries you can place all the static library files in the *-devel subpackage. When doing this you also must have a virtual Provide for the *-static package: %package devel Provides: foo-static = %{version}-%{release} Packages which explicitly need to link against the static version must BuildRequire: foo-static, so that the usage can be tracked. So probably false positive/bug of fedora-review tool. > [!]: EXTRA Spec file according to URL is the same as in SRPM. > Note: Spec file as given by url is not the same as in SRPM (see attached > diff). > > > Diff spec file in url and in SRPM > --------------------------------- > --- /home/jsynacek/work/reviews/nacl.spec 2012-09-03 12:39:55.432557126 +0200 > +++ /home/jsynacek/work/reviews/nacl/srpm-unpacked/nacl.spec 2012-09-03 > 12:42:23.269591873 +0200 > @@ -1,5 +1,4 @@ > Name: nacl > -# http://nacl.cr.yp.to/ > -URL: http://nacl.cace-project.eu/ > +URL: http://nacl.cr.yp.to/ > Version: 20110221 > Release: 1%{?dist} > Requires > I fine tuned the spec URL to credit the cace-project but forget to refresh the SRPM :) It should be fixed now (I fixed it without release bump).
Seems ok now, approving.
(In reply to comment #3) > Seems ok now, approving. Thanks for review.
New Package SCM Request ======================= Package Name: nacl Short Description: Networking and Cryptography library Owners: jskarvad Branches: f17 f18 InitialCC:
Git done (by process-git-requests).
(In reply to comment #6) > Git done (by process-git-requests). Thanks.
nacl-20110221-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2012-13290/nacl-20110221-2.fc18
nacl-20110221-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nacl-20110221-3.fc18
Package nacl-20110221-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing nacl-20110221-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-13543/nacl-20110221-3.fc18 then log in and leave karma (feedback).
nacl-20110221-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
nacl-20110221-15.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ee03feec9
nacl-20110221-15.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-15ce041700
nacl-20110221-15.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-15ce041700
nacl-20110221-15.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ee03feec9
cjdns-17.3-10.el7 nacl-20110221-15.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ee03feec9
cjdns-17.3-10.el7, nacl-20110221-15.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ee03feec9
cjdns-17.3-10.el7, nacl-20110221-15.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
nacl-20110221-15.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.