Bug 838406 - Have all forms use POST
Summary: Have all forms use POST
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Beaker
Classification: Retired
Component: web UI
Version: 0.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: beaker-dev-list
QA Contact: tools-bugs
URL:
Whiteboard: ImplementationQuality
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-09 02:26 UTC by Raymond Mancy
Modified: 2016-07-28 01:01 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-28 01:01:20 UTC
Embargoed:


Attachments (Terms of Use)

Description Raymond Mancy 2012-07-09 02:26:43 UTC
Many of our forms use GET. They should be using POST unless there is a great reason not to.

Comment 4 Dan Callaghan 2016-07-27 07:02:29 UTC
I think the only remaining forms which are improperly submitted using GET are:

/save_note (Notes tab on the system page)
/save_exclude (Excluded Families tab on the system page)
/really_cancel (old job cancellation page)
/tasks/disable_from_ui (Disable button on tasks grid)
/configuration/remove (Clear Current Value button on config grid)
/configuration/save (form on config item page)
/retentiontag/delete (Delete button on retention tags grid)
/retentiontag/save (form on new retention tag page)
/retentiontag/save_edit (form on edit retention tag page)
/keytypes/remove (Remove button on key types grid)
/keytypes/save (form on new key type page and edit key type page)
/osversions/save (form on OS version page)

Comment 5 Roman Joost 2016-07-28 01:00:38 UTC
I'm closing this particular bug, since it is something which will be fixed eventually by moving to back bone and a REST api. Implementing API endpoints and using Backbone will make it much harder to use GET instead of POST (perhaps it's not even possible).


Note You need to log in before you can comment on or make changes to this bug.