Bug 838516 - RESTAPI: api incorrectly describes host.nics.add() parameters
Summary: RESTAPI: api incorrectly describes host.nics.add() parameters
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine-restapi
Version: 3.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: Ori Liel
QA Contact: Yaniv Kaul
URL:
Whiteboard: infra, network
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-09 10:31 UTC by Michael Pasternak
Modified: 2015-09-22 13:09 UTC (History)
10 users (show)

Fixed In Version: si13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-12-04 20:01:44 UTC
oVirt Team: ---
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Michael Pasternak 2012-07-09 10:31:21 UTC 
Description of problem:

1. api reports that 
     
        [@param hostnic.bonding.slaves.host_nic: collection]

optional, while validates: "bonding.slaves.id|name"

2. api reports as add() parameters

        [@param hostnic.ip.gateway: string]
        [@param hostnic.boot_protocol: string]
        [@param hostnic.mac: string]
        [@param hostnic.ip.address: string]
        [@param hostnic.ip.netmask: string]

while no ip related info is not manageable via this interface.
Comment 1 Ori Liel 2012-08-05 13:22:28 UTC 
http://gerrit.ovirt.org/#/c/6111/

merged, commit 3de04fba32ccbb104d95ef9f8d0cf7ca8917471d
Comment 2 Ori Liel 2012-08-07 05:57:01 UTC 
ignore last commit number, correct commit: f39263aaae3d198f6ca9980b741948cc2ea86968
Comment 3 Avi Tal 2012-08-12 16:06:00 UTC 
Verify on SI13.2 - FAILED

http://emerald-31-vdc.qa.lab.tlv.redhat.com/api?rsdl:

<parameter required="false" type="xs:string">
 <name>hostnic.ip.gateway</name>
</parameter>
<parameter required="false" type="xs:string">
 <name>hostnic.boot_protocol</name>
</parameter>
<parameter required="false" type="xs:string">
 <name>hostnic.mac</name>
</parameter>
<parameter required="false" type="xs:string">
 <name>hostnic.ip.address</name>
</parameter>
<parameter required="false" type="xs:string">
 <name>hostnic.ip.netmask</name>
Comment 4 Itamar Heim 2012-08-14 05:40:58 UTC 
mike - related to bug 846950?
Comment 5 lpeer 2012-08-14 06:35:31 UTC 
(In reply to comment #4)
> mike - related to bug 846950?

No, this bug is about host nics properties and the other is about adding nics to templates.
Comment 6 Ori Liel 2012-08-26 08:17:45 UTC 
The fix is actually ok.

the parameters: 'hostnic.ip.gateway', 'hostnic.boot_protocol', 'hostnic.mac', 'hostnic.ip.address', 'hostnic.ip.netmask' should have been removed from 'add' signature, not from 'update' signature, and this is indeed the case. These parameters now only appear for update signature. 

Please re-check
Comment 7 Avi Tal 2012-08-26 09:10:52 UTC 
verify on si15.1 - PASS

these fields appear only for PUT command
Note You need to log in before you can comment on or make changes to this bug.