Bug 838870 - Review Request: rubygem-therubyracer - Embed the V8 Javascript interpreter into Ruby
Summary: Review Request: rubygem-therubyracer - Embed the V8 Javascript interpreter in...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 838801
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-10 10:27 UTC by Bohuslav "Slavek" Kabrda
Modified: 2012-07-16 06:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-16 06:11:23 UTC
Type: ---
Embargoed:
vondruch: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Bohuslav "Slavek" Kabrda 2012-07-10 10:27:36 UTC
Spec URL: http://bkabrda.fedorapeople.org/pkgs/therubyracer/rubygem-therubyracer.spec
SRPM URL: http://bkabrda.fedorapeople.org/pkgs/therubyracer/rubygem-therubyracer-0.11.0-0.1.beta5.fc17.src.rpm
Description:
Call javascript code and manipulate javascript objects from ruby. Call ruby
code and manipulate ruby objects from javascript.
Fedora Account System Username: bkabrda

Comment 1 Vít Ondruch 2012-07-10 10:35:52 UTC
I'll take it for a review

Comment 2 Vít Ondruch 2012-07-10 11:59:14 UTC
* Rename %{fedorarel} to %{release}
  - Not a show stopper, but the %{release} macro is supported by rpmdev-bumpspec,
    so the updated release is not appended at the end of Release string.

* The "Rakefile shouldn't be executable" comment is misleading
  - Since the file is not executable, but you are just removing shebang

Nonetheless, these are just minor nits, so I'll approve the package as soon as the rubygem-ref is available in the Rawhide and I'll be able to test the Koji build (it builds just fine locally).

Comment 3 Bohuslav "Slavek" Kabrda 2012-07-12 05:57:54 UTC
(In reply to comment #2)
> * Rename %{fedorarel} to %{release}
>   - Not a show stopper, but the %{release} macro is supported by
> rpmdev-bumpspec,
>     so the updated release is not appended at the end of Release string.
> 

Ah, yes. Will do before commiting to dist-git.

> * The "Rakefile shouldn't be executable" comment is misleading
>   - Since the file is not executable, but you are just removing shebang
> 

You are right, I will fix that as well

> Nonetheless, these are just minor nits, so I'll approve the package as soon
> as the rubygem-ref is available in the Rawhide and I'll be able to test the
> Koji build (it builds just fine locally).

Here is the koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4235854

Comment 4 Vít Ondruch 2012-07-12 06:01:26 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Nonetheless, these are just minor nits, so I'll approve the package as soon
> > as the rubygem-ref is available in the Rawhide and I'll be able to test the
> > Koji build (it builds just fine locally).
> 
> Here is the koji build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4235854

Great, thank you. All my concerns are gone now => APPROVED

Comment 5 Bohuslav "Slavek" Kabrda 2012-07-12 06:03:46 UTC
Thanks for the review!

New Package SCM Request
=======================
Package Name: rubygem-therubyracer
Short Description: Embed the V8 Javascript interpreter into Ruby
Owners: bkabrda
Branches: 
InitialCC:

Comment 6 Gwyn Ciesla 2012-07-15 02:42:49 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.