Spec URL: http://bkabrda.fedorapeople.org/pkgs/therubyracer/rubygem-therubyracer.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/therubyracer/rubygem-therubyracer-0.11.0-0.1.beta5.fc17.src.rpm Description: Call javascript code and manipulate javascript objects from ruby. Call ruby code and manipulate ruby objects from javascript. Fedora Account System Username: bkabrda
I'll take it for a review
* Rename %{fedorarel} to %{release} - Not a show stopper, but the %{release} macro is supported by rpmdev-bumpspec, so the updated release is not appended at the end of Release string. * The "Rakefile shouldn't be executable" comment is misleading - Since the file is not executable, but you are just removing shebang Nonetheless, these are just minor nits, so I'll approve the package as soon as the rubygem-ref is available in the Rawhide and I'll be able to test the Koji build (it builds just fine locally).
(In reply to comment #2) > * Rename %{fedorarel} to %{release} > - Not a show stopper, but the %{release} macro is supported by > rpmdev-bumpspec, > so the updated release is not appended at the end of Release string. > Ah, yes. Will do before commiting to dist-git. > * The "Rakefile shouldn't be executable" comment is misleading > - Since the file is not executable, but you are just removing shebang > You are right, I will fix that as well > Nonetheless, these are just minor nits, so I'll approve the package as soon > as the rubygem-ref is available in the Rawhide and I'll be able to test the > Koji build (it builds just fine locally). Here is the koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4235854
(In reply to comment #3) > (In reply to comment #2) > > Nonetheless, these are just minor nits, so I'll approve the package as soon > > as the rubygem-ref is available in the Rawhide and I'll be able to test the > > Koji build (it builds just fine locally). > > Here is the koji build: > http://koji.fedoraproject.org/koji/taskinfo?taskID=4235854 Great, thank you. All my concerns are gone now => APPROVED
Thanks for the review! New Package SCM Request ======================= Package Name: rubygem-therubyracer Short Description: Embed the V8 Javascript interpreter into Ruby Owners: bkabrda Branches: InitialCC:
Git done (by process-git-requests).