Red Hat Bugzilla – Bug 839033
The engine-config tool doesn't update correctly AdUserPassword
Last modified: 2015-03-04 19:18:08 EST
Description of problem:
The engine-config tool doesn't update correctly the AdUserPassword configuration parameter, it always saves to the database an empty string, regardless of the value provided in the command line.
This also means that engine-manage-domains will apparently work correctly, but will not add the domains correctly to the engine.
Version-Release number of selected component (if applicable):
Master branch, commit 2e4faddde925ce4617eeec23a4e18659d6f90ae7.
Steps to Reproduce:
1. Create a custom configuration file with the following content (this is to simulate the behaviour of engine-manage-domains calling engine-config):
cat > /tmp/f.conf <<.
2. Create a password file with the content of updated content of AdUserPassword (as engine-manage-domains would do):
echo example.com:mypassword > /tmp/f.pass
3. Run the engine-config tool:
# engine-config -s AdUserPassword --admin-pass-file /tmp/f.pass -p /tmp/f.conf
# echo $?
The tool returns 0 and doesn't print any error message, but the value in the database is not updated correctly:
engine=> select * from vdc_options where option_name = 'AdUserPassword';
option_id | option_name | option_value | version
10 | AdUserPassword | | general
The tool should either return an error value or update the database correctly.
I think this error has been introduced by the change that adds the --admin-pass-file option, as it doesn't handle correctly composite passwords like AdUserPassword.
Take into account that there is already a change proposed to fix this bug:
Comment #1 is wrong, that patch doesn't fix this bug, but other issues.
Suggested patch - http://gerrit.ovirt.org/#/c/6191/